Skip to content

Fix PHPStan return.empty errors in core methods #11017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huzaifaalmesbah wants to merge 1 commit into from
Closed

Fix PHPStan return.empty errors in core methods #11017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/wp-includes/class-wp-query.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4816,7 +4816,7 @@ public function is_main_query() {
* @global int $numpages
*
* @param WP_Post|object|int $post WP_Post instance or Post ID/object.
* @return true True when finished.
* @return bool True on success, false on failure.
*/
public function setup_postdata( $post ) {
global $id, $authordata, $currentday, $currentmonth, $page, $pages, $multipage, $more, $numpages;
Expand All @@ -4826,12 +4826,12 @@ public function setup_postdata( $post ) {
}

if ( ! $post ) {
return;
return false;
}

$elements = $this->generate_postdata( $post );
if ( false === $elements ) {
return;
return false;
}

$id = $elements['id'];
Expand Down
2 changes: 1 addition & 1 deletion src/wp-includes/theme.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3095,7 +3095,7 @@ function _remove_theme_support( $feature ) {
return false;
}
add_theme_support( 'custom-header', array( 'uploads' => false ) );
return; // Do not continue - custom-header-uploads no longer exists.
return true; // Do not continue - custom-header-uploads no longer exists.
}

if ( ! isset( $_wp_theme_features[ $feature ] ) ) {
Expand Down
Loading