Skip to content

Remove floats from customlinks#10997

Closed
audrasjb wants to merge 5 commits intoWordPress:trunkfrom
audrasjb:menu-custom-links-admin-reskin
Closed

Remove floats from customlinks#10997
audrasjb wants to merge 5 commits intoWordPress:trunkfrom
audrasjb:menu-custom-links-admin-reskin

Conversation

@audrasjb
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 21, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props audrasjb, sabernhardt, shailu25.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@shail-mehta
Copy link
Copy Markdown
Member

I believe that if we set the input box width to 100%, we may also need to adjust the button alignment, as it does not appear to be properly aligned at the moment. It should support alignment options such as right, center, or left, as appropriate.

Just sharing my thoughts.

Currently, it appears as shown here: https://prnt.sc/GRIgTITSt3Zr

Copy link
Copy Markdown

@sabernhardt sabernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The floating issue already happened in WordPress 6.9, but it is more noticeable now. The floating labels' top margin is too small for the larger input size.

The Add to Menu button alignment expects multiple elements in the .button-controls container with justify-content: space-between. The Custom Links section only has the one button, and that could use justify-content: flex-end. When JS is turned off, other sections can hide the Select All checkbox, moving the Add to Menu button closer to the center.

I would also like to remove the howto class from the labels because the gray text seems more inappropriate now.

Comment thread src/wp-admin/css/nav-menus.css
Comment thread src/wp-admin/css/nav-menus.css Outdated
@audrasjb
Copy link
Copy Markdown
Contributor Author

Thanks for the comments! If anyone is able to rebuild a PR for this, it would be really appreciated because I'm not sure I have time to update this one in time before RC1

@github-actions
Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 62097
GitHub commit: d9f1249

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions Bot closed this Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants