64250 redirect guess 404 permalink by jonnynews · Pull Request #10975 · WordPress/wordpress-develop

jonnynews · 2026-02-18T21:26:18Z

Trac ticket: https://core.trac.wordpress.org/ticket/64250

Use of AI Tools

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

…alink()

Co-authored-by: Weston Ruter <[email protected]>

Co-authored-by: Mukesh Panchal <[email protected]>

… control This commit introduces the `search_position` parameter to the `WP_Query` class, allowing developers to specify search behavior for posts: finding terms at the start, end, or anywhere within fields. Corresponding functionality in `canonical.php` has also been updated, and comprehensive unit tests were added to ensure reliability of the new behavior.

westonruter · 2026-02-18T21:32:13Z

 	 *     @type int             $day                    Day of the month. Default empty. Accepts numbers 1-31.
 	 *     @type bool            $exact                  Whether to search by exact keyword. Default false.
+	 *                                                   Cannot be used together with `$search_position`.
+	 *     @type bool            $search_position        Whether to search start, ends or is anywhere within keyword. Default anywhere.


Suggested change

* @type bool $search_position Whether to search start, ends or is anywhere within keyword. Default anywhere.

* @type string $search_position Whether to search start, ends or is anywhere within keyword. May be 'start', 'end', or the default 'anywhere'.

github-actions · 2026-02-18T21:43:51Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @jonnynews.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props altf4falt, spacedmonkey, westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2026-02-18T22:09:30Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

peterwilsoncc

I've added a few notes inline.

peterwilsoncc · 2026-02-18T21:55:43Z

 		$query_vars               = &$this->query_vars;
 		$this->query_vars_changed = true;

+		if ( ! empty( $query_vars['exact'] ) && ! empty( $query_vars['search_position'] ) ) {


Let's allow a dev to pass both exact => true, search_position => anywhere without throwing a notice, as it's the documented default.

Add search_position => '' to fill_query_vars() method.

peterwilsoncc · 2026-02-18T21:58:33Z

+	 *
+	 * @ticket 64250
+	 *
+	 * @dataProvider data_search_position_values


Per unit testing docs for providers used for a single test

Suggested change

* @dataProvider data_search_position_values

* @dataProvider data_search_position_with_different_values

peterwilsoncc · 2026-02-18T21:58:47Z

+	 *
+	 * @return array
+	 */
+	public function data_search_position_values() {


As above.

Suggested change

public function data_search_position_values() {

public function test_search_position_with_different_values() {

peterwilsoncc · 2026-02-18T22:01:00Z

+			array(
+				'post_status'  => 'publish',
+				'post_title'   => 'alpha beta gamma',
+				'post_content' => 'delta epsilon zeta',


Can you add the content to the shared fixture and remove the need for creating the post here? If so, it would speed up the tests slightly.

peterwilsoncc · 2026-02-18T22:13:32Z

+	 *
+	 * @ticket 64250
+	 */
+	public function test_search_position_with_invalid_value() {


A data provider with a variety of types would be helpful to ensure nothing errors:

You'll need to fix the coding standareds for alignment

array( 'null' => array( null ), 'true' => array( true ), 'false' => array( false ), 'int' => array( 123 ), 'float' => array( 123.456 ), 'string' => array( 'test' ), 'empty' => array( '' ), 'zero' => array( 0 ), 'negative' => array( -1 ), 'array' => array( array( 'test' ) ), 'empty array' => array( array() ), );

peterwilsoncc · 2026-02-18T22:14:18Z

 	 * @since 5.3.0 Introduced the `$meta_type_key` parameter.
 	 * @since 6.1.0 Introduced the `$update_menu_item_cache` parameter.
 	 * @since 6.2.0 Introduced the `$search_columns` parameter.
+	 * @since 7.0.0 Introduced the `$starts_with` parameter.


Suggested change

* @since 7.0.0 Introduced the `$starts_with` parameter.

* @since 7.0.0 Introduced the `$search_position` parameter.

peterwilsoncc · 2026-02-18T22:20:16Z

In this file there are a few tests to ensure the default colums are used for empty/invalid search_columns values. Add assertions to ensure that the slug is not included in those tests.

anandrajaram21 and others added 17 commits November 19, 2025 21:46

refactor: replace direct SQL with WP_Query in redirect_guess_404_perm…

ae6a847

…alink()

perf: optimize wp query and remove superfluous comments

ce90699

chore: change filter function to a static function

9b52804

Merge branch 'trunk' into 64250-redirect-guess-404-permalink

4532fae

feat: update approach to use wp-query instead of manual searching

3da7e89

feat: resolve copilot PR review comments

c420204

Use array_first instead of posts[0]

7eed5d7

Co-authored-by: Weston Ruter <[email protected]>

Add check for post_id to be integer

ccc2e39

Co-authored-by: Weston Ruter <[email protected]>

feat: remove post_name from default search columns

6021fd9

doc: update comment to be more descriptive

243ac98

chore: fix phpcs error in class-wp-query

3e8210f

feat: update test to use an existing but unsupported search column

940add6

feat: include suppress filters in wp query args and update filter docs

ff23ab9

feat: change 'true' to true

07df29a

Merge branch 'trunk' into 64250-redirect-guess-404-permalink

5bcf66f

Apply suggestion from @mukeshpanchal27

cf4de84

Co-authored-by: Mukesh Panchal <[email protected]>

westonruter reviewed Feb 18, 2026

View reviewed changes

Merge branch 'trunk' into 64250-redirect-guess-404-permalink-v2

9b17942

peterwilsoncc requested changes Feb 18, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

64250 redirect guess 404 permalink#10975

64250 redirect guess 404 permalink#10975
jonnynews wants to merge 18 commits intoWordPress:trunkfrom
spacedmonkey:64250-redirect-guess-404-permalink-v2

jonnynews commented Feb 18, 2026

Uh oh!

westonruter Feb 18, 2026

Uh oh!

github-actions Bot commented Feb 18, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Feb 18, 2026

Uh oh!

peterwilsoncc left a comment

Uh oh!

peterwilsoncc Feb 18, 2026

Uh oh!

peterwilsoncc Feb 18, 2026

Uh oh!

peterwilsoncc Feb 18, 2026

Uh oh!

peterwilsoncc Feb 18, 2026

Uh oh!

peterwilsoncc Feb 18, 2026 •

edited

Loading

Uh oh!

peterwilsoncc Feb 18, 2026

Uh oh!

mukeshpanchal27 Feb 19, 2026

Uh oh!

peterwilsoncc Feb 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	* @type bool $search_position Whether to search start, ends or is anywhere within keyword. Default anywhere.
	* @type string $search_position Whether to search start, ends or is anywhere within keyword. May be 'start', 'end', or the default 'anywhere'.

	* @dataProvider data_search_position_values
	* @dataProvider data_search_position_with_different_values

	public function data_search_position_values() {
	public function test_search_position_with_different_values() {

	* @since 7.0.0 Introduced the `$starts_with` parameter.
	* @since 7.0.0 Introduced the `$search_position` parameter.

Conversation

jonnynews commented Feb 18, 2026

Use of AI Tools

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unlinked Accounts

Uh oh!

github-actions Bot commented Feb 18, 2026

Test using WordPress Playground

Some things to be aware of

Uh oh!

peterwilsoncc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

peterwilsoncc Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

github-actions Bot commented Feb 18, 2026 •

edited

Loading

peterwilsoncc Feb 18, 2026 •

edited

Loading