Skip to content

HTML5 script support is always true #10919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sirreal wants to merge 9 commits into from
Closed

HTML5 script support is always true #10919

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
38cc041
Themes: Make current_theme_supports( 'html5', 'script' ) always retur…
sirreal Feb 12, 2026
4d295dc
Update comment and add since annotation
sirreal Feb 13, 2026
fc5bd41
Remove extraneous assertions
sirreal Feb 13, 2026
ff6bc02
Add since annotation
sirreal Feb 13, 2026
a52d609
Remove redundant script from default theme supports
sirreal Feb 13, 2026
6423810
Add theme supports schema REST API test
sirreal Feb 13, 2026
21ba9e3
Use get_theme_support() in current_theme_supports()
sirreal Feb 13, 2026
8ffcd66
Move custom-header-uploads override to get_theme_support
sirreal Feb 13, 2026
15176fc
Revert "Move custom-header-uploads override to get_theme_support"
sirreal Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/wp-includes/theme.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3193,6 +3193,12 @@ function current_theme_supports( $feature, ...$args ) {
* Specific areas of HTML5 support *must* be passed via an array to add_theme_support().
*/
$type = $args[0];

// HTML5 script support is always enabled since non-HTML5 script output was removed in 7.0.
Copy link
Copy Markdown
Member Author

@sirreal sirreal Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// HTML5 script support is always enabled since non-HTML5 script output was removed in 7.0.

if ( 'html5' === $feature && 'script' === $type ) {
return true;
}

return in_array( $type, $_wp_theme_features[ $feature ][0], true );

case 'custom-logo':
Expand Down
22 changes: 22 additions & 0 deletions tests/phpunit/tests/theme/support.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,28 @@ public function test_supports_html5_invalid() {
$this->assertFalse( current_theme_supports( 'html5' ) );
}

/**
* Tests that `current_theme_supports( 'html5', 'script' )` always returns true.
*
* Non-HTML5 script output was removed in WordPress 7.0, so script support
* is now always enabled regardless of theme configuration.
*
* @ticket 64442
*/
public function test_html5_script_support_always_true() {
// Should be true even without any theme support registered.
remove_theme_support( 'html5' );
$this->assertTrue( current_theme_supports( 'html5', 'script' ) );

// Should still be true after adding other html5 types but not script.
add_theme_support( 'html5', array( 'comment-form' ) );
$this->assertTrue( current_theme_supports( 'html5', 'script' ) );

// Other types should still work normally.
$this->assertTrue( current_theme_supports( 'html5', 'comment-form' ) );
$this->assertFalse( current_theme_supports( 'html5', 'search-form' ) );
}

/**
* @ticket 51390
*
Expand Down
Loading