Fix: Replace deprecated wp.updates.l10n.updating with wp.i18n.__

src/js/_enqueues/wp/theme.js

@@ -8,13 +8,12 @@ window.wp = window.wp || {};
 ( function($) {
 
 // Set up our namespace...
-var themes, l10n;
+var themes;
 themes = wp.themes = wp.themes || {};
 
 // Store the theme data and settings for organized and quick access.
 // themes.data.settings, themes.data.themes, themes.data.l10n.
 themes.data = _wpThemeSettings;
-l10n = themes.data.l10n;
 
 // Shortcut for isInstall check.
 themes.isInstall = !! themes.data.settings.isInstall;
@@ -119,7 +118,7 @@ themes.view.Appearance = wp.Backbone.View.extend({
 		view.render();
 		this.searchContainer
 			.find( '.search-box' )
-			.append( $.parseHTML( '<label for="wp-filter-search-input">' + l10n.search + '</label>' ) )
+			.append( $.parseHTML( '<label for="wp-filter-search-input">' + wp.i18n.__( themes.data.l10n.search ) + '</label>' ) )
 			.append( view.el );
 
 		this.searchContainer.on( 'submit', function( event ) {
@@ -973,9 +972,9 @@ themes.view.Preview = themes.view.Details.extend({
 	collapse: function( event ) {
 		var $button = $( event.currentTarget );
 		if ( 'true' === $button.attr( 'aria-expanded' ) ) {
-			$button.attr({ 'aria-expanded': 'false', 'aria-label': l10n.expandSidebar });
+			$button.attr({ 'aria-expanded': 'false', 'aria-label': wp.i18n.__( themes.data.l10n.expandSidebar ) });
 		} else {
-			$button.attr({ 'aria-expanded': 'true', 'aria-label': l10n.collapseSidebar });
+			$button.attr({ 'aria-expanded': 'true', 'aria-label': wp.i18n.__( themes.data.l10n.collapseSidebar ) });
 		}
 
 		this.$el.toggleClass( 'collapsed' ).toggleClass( 'expanded' );
@@ -1221,7 +1220,7 @@ themes.view.Themes = wp.Backbone.View.extend({
 
 		// 'Add new theme' element shown at the end of the grid.
 		if ( ! themes.isInstall && themes.data.settings.canInstall ) {
-			this.$el.append( '<div class="theme add-new-theme"><a href="' + themes.data.settings.installURI + '"><div class="theme-screenshot"><span aria-hidden="true"></span></div><h2 class="theme-name">' + l10n.addNew + '</h2></a></div>' );
+			this.$el.append( '<div class="theme add-new-theme"><a href="' + themes.data.settings.installURI + '"><div class="theme-screenshot"><span aria-hidden="true"></span></div><h2 class="theme-name">' + wp.i18n.__( themes.data.l10n.addNew ) + '</h2></a></div>' );
 		}
 
 		this.parent.page++;
@@ -1277,7 +1276,7 @@ themes.view.Themes = wp.Backbone.View.extend({
 				$modal.find( '.notice-warning' )
 					.removeClass( 'notice-large' )
 					.addClass( 'updating-message' )
-					.find( 'p' ).text( wp.updates.l10n.updating );
+					.find( 'p' ).text( wp.i18n.__( 'Updating...' ) );
 			} else if ( $card.find( '.notice-error' ).length ) {
 				$modal.find( '.notice-warning' ).remove();
 			}
@@ -1356,9 +1355,9 @@ themes.view.Themes = wp.Backbone.View.extend({
 	// Dispatch audible search results feedback message.
 	announceSearchResults: function( count ) {
 		if ( 0 === count ) {
-			wp.a11y.speak( l10n.noThemesFound );
+			wp.a11y.speak( wp.i18n.__( themes.data.l10n.noThemesFound ) );
 		} else {
-			wp.a11y.speak( l10n.themesFound.replace( '%d', count ) );
+			wp.a11y.speak( wp.i18n.sprintf( wp.i18n.__( themes.data.l10n.themesFound ), count ) );
 		}
 	}
 });
@@ -1676,7 +1675,7 @@ themes.view.Installer = themes.view.Appearance.extend({
 		this.listenTo( this.collection, 'query:fail', function() {
 			$( 'body' ).removeClass( 'loading-content' );
 			$( '.theme-browser' ).find( 'div.error' ).remove();
-			$( '.theme-browser' ).find( 'div.themes' ).before( '<div class="notice notice-error"><p>' + l10n.error + '</p><p><button class="button try-again">' + l10n.tryAgain + '</button></p></div>' );
+			$( '.theme-browser' ).find( 'div.themes' ).before( '<div class="notice notice-error"><p>' + wp.i18n.sprintf( wp.i18n.__( themes.data.l10n.error ), 'https://wordpress.org/support/forums/' ) + '</p><p><button class="button try-again">' + wp.i18n.__( themes.data.l10n.tryAgain ) + '</button></p></div>' );
 			$( '.theme-browser .error .try-again' ).on( 'click', function( e ) {
 				e.preventDefault();
 				$( 'input.wp-filter-search' ).trigger( 'input' );
@@ -1808,7 +1807,7 @@ themes.view.Installer = themes.view.Appearance.extend({
 		}
 
 		if ( ! tags ) {
-			wp.a11y.speak( l10n.selectFeatureFilter );
+			wp.a11y.speak( wp.i18n.__( themes.data.l10n.selectFeatureFilter ) );
 			return;
 		}
 

src/wp-admin/theme-install.php

@@ -54,30 +54,28 @@
 			'adminUrl'   => parse_url( self_admin_url(), PHP_URL_PATH ),
 		),
 		'l10n'            => array(
-			'addNew'              => __( 'Add Theme' ),
-			'search'              => __( 'Search Themes' ),
-			'upload'              => __( 'Upload Theme' ),
-			'back'                => __( 'Back' ),
-			'error'               => sprintf(
-				/* translators: %s: Support forums URL. */
-				__( 'An unexpected error occurred. Something may be wrong with WordPress.org or this server&#8217;s configuration. If you continue to have problems, please try the <a href="%s">support forums</a>.' ),
-				__( 'https://wordpress.org/support/forums/' )
-			),
-			'tryAgain'            => __( 'Try Again' ),
+			'addNew'              => 'Add Theme',
+			'search'              => 'Search Themes',
+			'upload'              => 'Upload Theme',
+			'back'                => 'Back',
+			/* translators: %s: Support forums URL. */
+			'error'               => 'An unexpected error occurred. Something may be wrong with WordPress.org or this server&#8217;s configuration. If you continue to have problems, please try the <a href="%s">support forums</a>.',
+			'tryAgain'            => 'Try Again',
 			/* translators: %d: Number of themes. */
-			'themesFound'         => __( 'Number of Themes found: %d' ),
-			'noThemesFound'       => __( 'No themes found. Try a different search.' ),
-			'collapseSidebar'     => __( 'Collapse Sidebar' ),
-			'expandSidebar'       => __( 'Expand Sidebar' ),
+			'themesFound'         => 'Number of Themes found: %d',
+			'noThemesFound'       => 'No themes found. Try a different search.',
+			'collapseSidebar'     => 'Collapse Sidebar',
+			'expandSidebar'       => 'Expand Sidebar',
 			/* translators: Hidden accessibility text. */
-			'selectFeatureFilter' => __( 'Select one or more Theme features to filter by' ),
+			'selectFeatureFilter' => 'Select one or more Theme features to filter by',
 		),
 		'installedThemes' => array_keys( $installed_themes ),
 		'activeTheme'     => get_stylesheet(),
 	)
 );
 
 wp_enqueue_script( 'theme' );
+wp_set_script_translations( 'theme' );
 wp_enqueue_script( 'updates' );
 
 if ( $tab ) {

src/wp-admin/themes.php

@@ -231,17 +231,18 @@
 			'adminUrl'      => parse_url( admin_url(), PHP_URL_PATH ),
 		),
 		'l10n'     => array(
-			'addNew'        => __( 'Add Theme' ),
-			'search'        => __( 'Search installed themes' ),
+			'addNew'        => 'Add Theme',
+			'search'        => 'Search installed themes',
 			/* translators: %d: Number of themes. */
-			'themesFound'   => __( 'Number of Themes found: %d' ),
-			'noThemesFound' => __( 'No themes found. Try a different search.' ),
+			'themesFound'   => 'Number of Themes found: %d',
+			'noThemesFound' => 'No themes found. Try a different search.',
 		),
 	)
 );
 
 add_thickbox();
 wp_enqueue_script( 'theme' );
+wp_set_script_translations( 'theme' );
 wp_enqueue_script( 'updates' );
 
 require_once ABSPATH . 'wp-admin/admin-header.php';