-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Fix: Clear up plugin cache after delete_plugins call to remove stale data #10843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hbhalodia
wants to merge
8
commits into
WordPress:trunk
Choose a base branch
from
hbhalodia:fix/issue-64568
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b39c5d7
CoreTrac-64568 Add wp_clean_plugins_cache to remove stale data after …
hbhalodia 0677f37
CoreTrac-64568 Update messaging for comment
hbhalodia c29ee85
Merge branch 'trunk' into fix/issue-64568
hbhalodia 60e7d09
Update the comment with new wordings
hbhalodia 3e61a6c
Add the unit test to verify the cache is deleted once delete_plugin i…
hbhalodia 75a44c2
Add @ticket comment to test function
hbhalodia 6edbddc
Merge branch 'trunk' into fix/issue-64568
hbhalodia 68a37c9
Merge branch 'trunk' into fix/issue-64568
hbhalodia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to other instance where core use
wp_clean_plugins_cache(). Can we have unit test that verify the behaviour?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!