Skip to content

Media: only add required attribute to media_upload_form on media screen #10558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adamsilverstein wants to merge 3 commits into from
Closed

Media: only add required attribute to media_upload_form on media screen #10558

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b54936
Media: only add required attribute to media_upload_form on media screen
adamsilverstein Nov 26, 2025
4e924eb
Ensure current_screen set before using
adamsilverstein Nov 26, 2025
dbe189a
address feedback
adamsilverstein Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/wp-admin/includes/media.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2277,6 +2277,8 @@ function media_upload_form( $errors = null ) {
*/
do_action( 'pre-html-upload-ui' ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.UseUnderscores

$current_screen = get_current_screen();
$required = $current_screen && 'media' === $current_screen->id ? ' required' : '';
Comment thread
adamsilverstein marked this conversation as resolved.
?>
<p id="async-upload-wrap">
<label class="screen-reader-text" for="async-upload">
Expand All @@ -2285,7 +2287,7 @@ function media_upload_form( $errors = null ) {
_ex( 'Upload', 'verb' );
?>
</label>
<input type="file" name="async-upload" id="async-upload" required />
<input type="file" name="async-upload" id="async-upload"<?php echo $required; ?> />
Comment thread
adamsilverstein marked this conversation as resolved.
<?php submit_button( _x( 'Upload', 'verb' ), 'primary', 'html-upload', false ); ?>
<a href="#" onclick="try{top.tb_remove();}catch(e){}; return false;"><?php _e( 'Cancel' ); ?></a>
</p>
Expand Down
Loading