Skip to content

Fix some instances of null array key access #10136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mukeshpanchal27 wants to merge 17 commits into from
Closed

Fix some instances of null array key access #10136

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
08d48cb
Update is_registered method to handle null template name
mukeshpanchal27 Oct 3, 2025
92aecfb
Update class-wp-block-bindings-registry.php
mukeshpanchal27 Oct 3, 2025
f0a6251
Update class-wp-block-pattern-categories-registry.php
mukeshpanchal27 Oct 3, 2025
9afab59
Change pattern_name parameter to nullable string
mukeshpanchal27 Oct 3, 2025
4549185
Update parameter types in is_registered method
mukeshpanchal27 Oct 3, 2025
fbdd678
Fix parameter type hint in is_registered method
mukeshpanchal27 Oct 3, 2025
7a6617c
Apply suggestions from code review
mukeshpanchal27 Oct 6, 2025
73b7df3
Add test for empty source name registration
mukeshpanchal27 Oct 6, 2025
0ea22bf
Add unit tests for WP_Block_Pattern_Categories_Registry::is_registered()
mukeshpanchal27 Oct 6, 2025
5ad8626
Add tests for WP_Block_Patterns_Registry methods
mukeshpanchal27 Oct 6, 2025
9fed959
Add unit tests for WP_Block_Styles_Registry::is_registered
mukeshpanchal27 Oct 6, 2025
11d25ce
Update WpBlockTemplatesRegistry.php
mukeshpanchal27 Oct 6, 2025
5581a47
Remove bool check
mukeshpanchal27 Oct 6, 2025
4a066b8
Run unit tests against PHP 8.5
mukeshpanchal27 Oct 6, 2025
1d47043
Check for null param
mukeshpanchal27 Oct 6, 2025
7165f9b
Move tests
mukeshpanchal27 Oct 6, 2025
7bc2cd2
Remove empty check
mukeshpanchal27 Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/wp-includes/class-wp-block-bindings-registry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,11 +249,11 @@ public function get_registered( string $source_name ) {
*
* @since 6.5.0
*
* @param string $source_name The name of the source.
* @param string|null $source_name The name of the source.
* @return bool `true` if the block bindings source is registered, `false` otherwise.
*/
public function is_registered( $source_name ) {
return isset( $this->sources[ $source_name ] );
return isset( $source_name, $this->sources[ $source_name ] );
}

/**
Expand Down
4 changes: 2 additions & 2 deletions src/wp-includes/class-wp-block-pattern-categories-registry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,11 +138,11 @@ public function get_all_registered( $outside_init_only = false ) {
*
* @since 5.5.0
*
* @param string $category_name Pattern category name including namespace.
* @param string|null $category_name Pattern category name including namespace.
* @return bool True if the pattern category is registered, false otherwise.
*/
public function is_registered( $category_name ) {
return isset( $this->registered_categories[ $category_name ] );
return isset( $category_name, $this->registered_categories[ $category_name ] );
}

/**
Expand Down
4 changes: 2 additions & 2 deletions src/wp-includes/class-wp-block-patterns-registry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,11 +238,11 @@ public function get_all_registered( $outside_init_only = false ) {
*
* @since 5.5.0
*
* @param string $pattern_name Block pattern name including namespace.
* @param string|null $pattern_name Block pattern name including namespace.
* @return bool True if the pattern is registered, false otherwise.
*/
public function is_registered( $pattern_name ) {
return isset( $this->registered_patterns[ $pattern_name ] );
return isset( $pattern_name, $this->registered_patterns[ $pattern_name ] );
}

public function __wakeup() {
Expand Down
6 changes: 3 additions & 3 deletions src/wp-includes/class-wp-block-styles-registry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,12 +181,12 @@ public function get_registered_styles_for_block( $block_name ) {
*
* @since 5.3.0
*
* @param string $block_name Block type name including namespace.
* @param string $block_style_name Block style name.
* @param string|null $block_name Block type name including namespace.
* @param string|null $block_style_name Block style name.
* @return bool True if the block style is registered, false otherwise.
*/
public function is_registered( $block_name, $block_style_name ) {
return isset( $this->registered_block_styles[ $block_name ][ $block_style_name ] );
return isset( $block_name, $block_style_name, $this->registered_block_styles[ $block_name ][ $block_style_name ] );
Comment thread
mukeshpanchal27 marked this conversation as resolved.
}

/**
Expand Down
4 changes: 2 additions & 2 deletions src/wp-includes/class-wp-block-templates-registry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,11 +204,11 @@ public function get_by_query( $query = array() ) {
*
* @since 6.7.0
*
* @param string $template_name Template name.
* @param string|null $template_name Template name.
* @return bool True if the template is registered, false otherwise.
*/
public function is_registered( $template_name ) {
return isset( $this->registered_templates[ $template_name ] );
return isset( $template_name, $this->registered_templates[ $template_name ] );
}

/**
Expand Down
Loading