Skip to content

Commit 119efb6

Browse files
Reinitialize REST server in sideload tests
The parent set_up() creates and initializes the REST server before individual test methods run, so the filter alone is not enough. Reset the server global and re-fire rest_api_init after enabling the filter.
1 parent b122f7f commit 119efb6

1 file changed

Lines changed: 25 additions & 0 deletions

File tree

tests/phpunit/tests/rest-api/rest-attachments-controller.php

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3163,6 +3163,11 @@ static function ( $data ) use ( &$captured_data ) {
31633163
*/
31643164
public function test_sideload_scaled_image() {
31653165
add_filter( 'wp_client_side_media_processing_enabled', '__return_true' );
3166+
// Reinitialize REST server so the sideload route is registered.
3167+
global $wp_rest_server;
3168+
$wp_rest_server = new Spy_REST_Server();
3169+
do_action( 'rest_api_init', $wp_rest_server );
3170+
31663171
wp_set_current_user( self::$author_id );
31673172

31683173
// First, create an attachment.
@@ -3217,6 +3222,11 @@ public function test_sideload_scaled_image() {
32173222
*/
32183223
public function test_sideload_scaled_image_requires_auth() {
32193224
add_filter( 'wp_client_side_media_processing_enabled', '__return_true' );
3225+
// Reinitialize REST server so the sideload route is registered.
3226+
global $wp_rest_server;
3227+
$wp_rest_server = new Spy_REST_Server();
3228+
do_action( 'rest_api_init', $wp_rest_server );
3229+
32203230
wp_set_current_user( self::$author_id );
32213231

32223232
// Create an attachment.
@@ -3247,6 +3257,11 @@ public function test_sideload_scaled_image_requires_auth() {
32473257
*/
32483258
public function test_sideload_route_includes_scaled_enum() {
32493259
add_filter( 'wp_client_side_media_processing_enabled', '__return_true' );
3260+
// Reinitialize REST server so the sideload route is registered.
3261+
global $wp_rest_server;
3262+
$wp_rest_server = new Spy_REST_Server();
3263+
do_action( 'rest_api_init', $wp_rest_server );
3264+
32503265
$server = rest_get_server();
32513266
$routes = $server->get_routes();
32523267

@@ -3270,6 +3285,11 @@ public function test_sideload_route_includes_scaled_enum() {
32703285
*/
32713286
public function test_sideload_scaled_unique_filename() {
32723287
add_filter( 'wp_client_side_media_processing_enabled', '__return_true' );
3288+
// Reinitialize REST server so the sideload route is registered.
3289+
global $wp_rest_server;
3290+
$wp_rest_server = new Spy_REST_Server();
3291+
do_action( 'rest_api_init', $wp_rest_server );
3292+
32733293
wp_set_current_user( self::$author_id );
32743294

32753295
// Create an attachment.
@@ -3305,6 +3325,11 @@ public function test_sideload_scaled_unique_filename() {
33053325
*/
33063326
public function test_sideload_scaled_unique_filename_conflict() {
33073327
add_filter( 'wp_client_side_media_processing_enabled', '__return_true' );
3328+
// Reinitialize REST server so the sideload route is registered.
3329+
global $wp_rest_server;
3330+
$wp_rest_server = new Spy_REST_Server();
3331+
do_action( 'rest_api_init', $wp_rest_server );
3332+
33083333
wp_set_current_user( self::$author_id );
33093334

33103335
// Create the first attachment.

0 commit comments

Comments
 (0)