Skip to content

Commit b122f7f

Browse files
Fix sideload tests for non-secure contexts
The sideload route is only registered when client-side media processing is enabled, which now requires SSL or localhost. Force-enable the filter in affected tests so routes register correctly in CI.
1 parent 77a504f commit b122f7f

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

tests/phpunit/tests/rest-api/rest-attachments-controller.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3162,6 +3162,7 @@ static function ( $data ) use ( &$captured_data ) {
31623162
* @requires function imagejpeg
31633163
*/
31643164
public function test_sideload_scaled_image() {
3165+
add_filter( 'wp_client_side_media_processing_enabled', '__return_true' );
31653166
wp_set_current_user( self::$author_id );
31663167

31673168
// First, create an attachment.
@@ -3215,6 +3216,7 @@ public function test_sideload_scaled_image() {
32153216
* @requires function imagejpeg
32163217
*/
32173218
public function test_sideload_scaled_image_requires_auth() {
3219+
add_filter( 'wp_client_side_media_processing_enabled', '__return_true' );
32183220
wp_set_current_user( self::$author_id );
32193221

32203222
// Create an attachment.
@@ -3244,6 +3246,7 @@ public function test_sideload_scaled_image_requires_auth() {
32443246
* @ticket 64737
32453247
*/
32463248
public function test_sideload_route_includes_scaled_enum() {
3249+
add_filter( 'wp_client_side_media_processing_enabled', '__return_true' );
32473250
$server = rest_get_server();
32483251
$routes = $server->get_routes();
32493252

@@ -3266,6 +3269,7 @@ public function test_sideload_route_includes_scaled_enum() {
32663269
* @requires function imagejpeg
32673270
*/
32683271
public function test_sideload_scaled_unique_filename() {
3272+
add_filter( 'wp_client_side_media_processing_enabled', '__return_true' );
32693273
wp_set_current_user( self::$author_id );
32703274

32713275
// Create an attachment.
@@ -3300,6 +3304,7 @@ public function test_sideload_scaled_unique_filename() {
33003304
* @requires function imagejpeg
33013305
*/
33023306
public function test_sideload_scaled_unique_filename_conflict() {
3307+
add_filter( 'wp_client_side_media_processing_enabled', '__return_true' );
33033308
wp_set_current_user( self::$author_id );
33043309

33053310
// Create the first attachment.

tests/phpunit/tests/rest-api/rest-schema-setup.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ class WP_Test_REST_Schema_Initialization extends WP_Test_REST_TestCase {
1616
public function set_up() {
1717
parent::set_up();
1818

19+
// Ensure client-side media processing is enabled so the sideload route is registered.
20+
add_filter( 'wp_client_side_media_processing_enabled', '__return_true' );
21+
1922
/** @var WP_REST_Server $wp_rest_server */
2023
global $wp_rest_server;
2124
$wp_rest_server = new Spy_REST_Server();

0 commit comments

Comments
 (0)