Skip to content

Don't merge this. Testing! #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
samcunliffe wants to merge 5 commits into from
Closed

Don't merge this. Testing! #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1d00202
Add dev fork readme note.
samcunliffe Jun 9, 2025
e15ea69
Stop `vale` failing for forked contributions (?)
samcunliffe Jun 9, 2025
dda8c10
More than 11 weasle sentences.
samcunliffe Jun 9, 2025
3b855e4
Try permissions.
samcunliffe Jun 9, 2025
1cbfefd
Contents read.
samcunliffe Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/linting.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ jobs:

lint-prose:
runs-on: ubuntu-latest
permissions:
contents: read
pull-requests: write
steps:
- name: Checkout source
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
Expand All @@ -71,5 +74,5 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
filter_mode: nofilter
filter_mode: diff_context
reporter: github-check
14 changes: 14 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,20 @@
</div>
<!-- markdownlint-restore -->

> [!CAUTION]
> This is Sam's dev fork.

This is quite a weasly sentence, I'm fairly sure that this might maybe work, maybe.

Check warning on line 11 in README.md

View workflow job for this annotation

GitHub Actions / lint-prose 

[vale] reported by reviewdog 🐶
[write-good.Weasel] 'quite' is a weasel word!

Raw Output:
{"message": "[write-good.Weasel] 'quite' is a weasel word!", "location": {"path": "README.md", "range": {"start": {"line": 11, "column": 9}}}, "severity": "WARNING"}

Check warning on line 11 in README.md

View workflow job for this annotation

GitHub Actions / lint-prose 

[vale] reported by reviewdog 🐶
[write-good.Weasel] 'fairly' is a weasel word!

Raw Output:
{"message": "[write-good.Weasel] 'fairly' is a weasel word!", "location": {"path": "README.md", "range": {"start": {"line": 11, "column": 38}}}, "severity": "WARNING"}
This is quite a weasly sentence, I'm fairly sure that this might maybe work, maybe.

Check warning on line 12 in README.md

View workflow job for this annotation

GitHub Actions / lint-prose 

[vale] reported by reviewdog 🐶
[write-good.Weasel] 'quite' is a weasel word!

Raw Output:
{"message": "[write-good.Weasel] 'quite' is a weasel word!", "location": {"path": "README.md", "range": {"start": {"line": 12, "column": 9}}}, "severity": "WARNING"}

Check warning on line 12 in README.md

View workflow job for this annotation

GitHub Actions / lint-prose 

[vale] reported by reviewdog 🐶
[write-good.Weasel] 'fairly' is a weasel word!

Raw Output:
{"message": "[write-good.Weasel] 'fairly' is a weasel word!", "location": {"path": "README.md", "range": {"start": {"line": 12, "column": 38}}}, "severity": "WARNING"}
This is quite a weasly sentence, I'm fairly sure that this might maybe work, maybe.

Check warning on line 13 in README.md

View workflow job for this annotation

GitHub Actions / lint-prose 

[vale] reported by reviewdog 🐶
[write-good.Weasel] 'quite' is a weasel word!

Raw Output:
{"message": "[write-good.Weasel] 'quite' is a weasel word!", "location": {"path": "README.md", "range": {"start": {"line": 13, "column": 9}}}, "severity": "WARNING"}

Check warning on line 13 in README.md

View workflow job for this annotation

GitHub Actions / lint-prose 

[vale] reported by reviewdog 🐶
[write-good.Weasel] 'fairly' is a weasel word!

Raw Output:
{"message": "[write-good.Weasel] 'fairly' is a weasel word!", "location": {"path": "README.md", "range": {"start": {"line": 13, "column": 38}}}, "severity": "WARNING"}
This is quite a weasly sentence, I'm fairly sure that this might maybe work, maybe.

Check warning on line 14 in README.md

View workflow job for this annotation

GitHub Actions / lint-prose 

[vale] reported by reviewdog 🐶
[write-good.Weasel] 'quite' is a weasel word!

Raw Output:
{"message": "[write-good.Weasel] 'quite' is a weasel word!", "location": {"path": "README.md", "range": {"start": {"line": 14, "column": 9}}}, "severity": "WARNING"}

Check warning on line 14 in README.md

View workflow job for this annotation

GitHub Actions / lint-prose 

[vale] reported by reviewdog 🐶
[write-good.Weasel] 'fairly' is a weasel word!

Raw Output:
{"message": "[write-good.Weasel] 'fairly' is a weasel word!", "location": {"path": "README.md", "range": {"start": {"line": 14, "column": 38}}}, "severity": "WARNING"}
This is quite a weasly sentence, I'm fairly sure that this might maybe work, maybe.

Check warning on line 15 in README.md

View workflow job for this annotation

GitHub Actions / lint-prose 

[vale] reported by reviewdog 🐶
[write-good.Weasel] 'quite' is a weasel word!

Raw Output:
{"message": "[write-good.Weasel] 'quite' is a weasel word!", "location": {"path": "README.md", "range": {"start": {"line": 15, "column": 9}}}, "severity": "WARNING"}

Check warning on line 15 in README.md

View workflow job for this annotation

GitHub Actions / lint-prose 

[vale] reported by reviewdog 🐶
[write-good.Weasel] 'fairly' is a weasel word!

Raw Output:
{"message": "[write-good.Weasel] 'fairly' is a weasel word!", "location": {"path": "README.md", "range": {"start": {"line": 15, "column": 38}}}, "severity": "WARNING"}
This is quite a weasly sentence, I'm fairly sure that this might maybe work, maybe.
This is quite a weasly sentence, I'm fairly sure that this might maybe work, maybe.
This is quite a weasly sentence, I'm fairly sure that this might maybe work, maybe.
This is quite a weasly sentence, I'm fairly sure that this might maybe work, maybe.
This is quite a weasly sentence, I'm fairly sure that this might maybe work, maybe.

This repository collects the [UCL ARC] recommendations for a research software
project in Python. It contains a template for new Python packages and a
[website] documenting our recommendations. We've turned on
Expand Down
Loading