Add label to theme-switcher button.#543
Merged
samcunliffe merged 2 commits intomainfrom Jun 5, 2025
Merged
Conversation
samcunliffe
added
enhancement
samcunliffe
commented
Jun 3, 2025
Member
|
Could we upstream this into the theme source? |
Member
Author
Yep. Deleting this whole custom thing is waiting on just-the-docs/just-the-docs#1223 (which I think is just-the-docs/just-the-docs#1099) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
as suggested by @jamesprime by adding an aria label to labelless button. Confirmed with macOS's "VoiceOver" screen reader...
As with the ☼ / ☾ it's a bit WET because it needs declaring and then the same lines appear in the switch conditional.