Conversation
Contributor
|
AdvancedHMC.jl documentation for PR #466 is available at: |
Merged
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
==========================================
+ Coverage 75.44% 77.66% +2.21%
==========================================
Files 21 21
Lines 1230 1240 +10
==========================================
+ Hits 928 963 +35
+ Misses 302 277 -25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Xianda Sun <[email protected]>
sunxd3
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #459.
With this PR, the example just prints
and does not show all diagonal entries anymore.
The problem with #446 is that it replaced the
show(io, x)definitions withshow(io, ::MIME"text/plain", x)definitions, instead of only defining the 3-argumentshowmethods when appropriate.This change implies that the 2-argument
showmethod currently uses the fallback of printing the full type information + all fields, which causes these enormous diagonal and dense metrics to be fully displayed.In this PR, in all cases where the 3-argument
showmethod was defined to print a single line I removed the::MIME"text/plain"argument since in principle such compact output is appropriate for the 2-argumentshowmethod as well; where the 3-argumentshowmethod was defined to print multiple lines, I added a 2-argument version that only prints a single line (showing a constructor of the type, sometimes with shortened arguments as in the case ofDiagEuclideanMetricshown above).