Skip to content

fix: retarget scaffold runtime to solverforge 0.8.8 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
blackopsrepl wants to merge 1 commit into from
Closed

fix: retarget scaffold runtime to solverforge 0.8.8 #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
`solverforge-cli` is the default entry point for new SolverForge applications. Treat the CLI as its own versioned product, distinct from the runtime crates and UI assets that generated projects target.

Current scaffold policy:
- generated projects currently target `solverforge 0.8.5`, `solverforge-ui 0.4.3`, and `solverforge-maps 2.1.3` as their crate dependency versions
- generated projects currently target `solverforge 0.8.8`, `solverforge-ui 0.4.3`, and `solverforge-maps 2.1.3` as their crate dependency versions
- `solverforge new <name>` is the only public scaffold path and produces a neutral shell
- users shape the app afterward through facts, entities, variables, constraints, and generated data
- generated docs and CLI version output must distinguish CLI version from scaffold runtime/UI target
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
Default entry point for new SolverForge projects.

Use this CLI to scaffold, grow, and manage SolverForge applications. Generated
projects currently target `solverforge 0.8.5`, `solverforge-ui 0.4.3`, and
projects currently target `solverforge 0.8.8`, `solverforge-ui 0.4.3`, and
`solverforge-maps 2.1.3` as their crate dependency versions, and that target
policy is part of the product surface rather than an invisible implementation
detail.
Expand Down
2 changes: 1 addition & 1 deletion src/commands/new.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ fn scaffold(
}

fn solverforge_dep_spec() -> String {
"{ version = \"0.8.5\", features = [\"serde\", \"console\", \"verbose-logging\"] }".to_string()
"{ version = \"0.8.8\", features = [\"serde\", \"console\", \"verbose-logging\"] }".to_string()
}

fn solverforge_ui_dep_spec() -> String {
Expand Down
10 changes: 5 additions & 5 deletions src/scaffold_target.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
pub const RUNTIME_TARGET_LABEL: &str = "solverforge 0.8.5";
pub const RUNTIME_TARGET_DISPLAY: &str = "SolverForge crate target 0.8.5";
pub const RUNTIME_SOURCE_PATH: &str = "crates.io: solverforge 0.8.5";
pub const RUNTIME_TARGET_LABEL: &str = "solverforge 0.8.8";
pub const RUNTIME_TARGET_DISPLAY: &str = "SolverForge crate target 0.8.8";
pub const RUNTIME_SOURCE_PATH: &str = "crates.io: solverforge 0.8.8";
pub const UI_SOURCE_PATH: &str = "crates.io: solverforge-ui 0.4.3";
pub const MAPS_SOURCE_PATH: &str = "crates.io: solverforge-maps 2.1.3";

Expand All @@ -9,9 +9,9 @@ pub const LONG_VERSION_TEXT: &str = concat!(
env!("CARGO_PKG_VERSION"),
"\nCLI version: ",
env!("CARGO_PKG_VERSION"),
"\nScaffold runtime target: SolverForge crate target 0.8.5",
"\nScaffold runtime target: SolverForge crate target 0.8.8",
"\nRuntime source: ",
"crates.io: solverforge 0.8.5",
"crates.io: solverforge 0.8.8",
"\nUI source: ",
"crates.io: solverforge-ui 0.4.3",
"\nMaps source: ",
Expand Down
8 changes: 4 additions & 4 deletions tests/scaffold_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ mod local_dependencies;

use local_dependencies::{pin_generated_project_to_local_solverforge, USE_PUBLISHED_DEPS_ENV};

const RUNTIME_DEP_LABEL: &str = "crates.io: solverforge 0.8.5";
const RUNTIME_DEP_LABEL: &str = "crates.io: solverforge 0.8.8";
const UI_DEP_LABEL: &str = "crates.io: solverforge-ui 0.4.3";
const MAPS_DEP_LABEL: &str = "crates.io: solverforge-maps 2.1.3";
const CLI_VERSION: &str = env!("CARGO_PKG_VERSION");
Expand Down Expand Up @@ -62,7 +62,7 @@ fn test_version_output_distinguishes_cli_from_runtime_target() {
assert!(
stdout.contains(&format!("solverforge-cli {}", CLI_VERSION))
&& stdout.contains(&format!("CLI version: {}", CLI_VERSION))
&& stdout.contains("Scaffold runtime target: SolverForge crate target 0.8.5")
&& stdout.contains("Scaffold runtime target: SolverForge crate target 0.8.8")
&& stdout.contains(RUNTIME_DEP_LABEL)
&& stdout.contains(UI_DEP_LABEL)
&& stdout.contains(MAPS_DEP_LABEL),
Expand Down Expand Up @@ -173,7 +173,7 @@ fn test_new_creates_neutral_project_files() {
);
assert!(
cargo_toml.contains(
"solverforge = { version = \"0.8.5\", features = [\"serde\", \"console\", \"verbose-logging\"] }"
"solverforge = { version = \"0.8.8\", features = [\"serde\", \"console\", \"verbose-logging\"] }"
) && cargo_toml.contains("solverforge-ui = { version = \"0.4.3\" }")
&& cargo_toml.contains("solverforge-maps = { version = \"2.1.3\" }"),
"unified scaffold should point at the current SolverForge, solverforge-ui, and solverforge-maps crate targets: {}",
Expand Down Expand Up @@ -247,7 +247,7 @@ fn test_new_readme_records_cli_and_runtime_versions_separately() {
readme.contains(&format!(
"CLI version used to scaffold this project: `{}`",
CLI_VERSION
)) && readme.contains("SolverForge runtime target for this scaffold: `solverforge 0.8.5`")
)) && readme.contains("SolverForge runtime target for this scaffold: `solverforge 0.8.8`")
&& readme.contains(RUNTIME_DEP_LABEL)
&& readme.contains(UI_DEP_LABEL)
&& readme.contains(MAPS_DEP_LABEL)
Expand Down
Loading