Zwave Lock: Support SLGA Migration#2944
Open
hcarter-775 wants to merge 4 commits intomainfrom
Open
Conversation
hcarter-775
requested review from
aleclorimer,
cbaumler,
cjswedes,
ctowns and
nand-nor
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 72 files 510 suites 0s ⏱️ Results for commit 7b30cc6. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 7b30cc6 |
Contributor
|
For some reason my comment is failing to save when i try to add an in line comment, but I was wondering if in addition to the lockCodes.migrated attribute should we also set a persisted flag to indicated the migrated state? Just since otherwise it would fallback to the legacy handling if the state cache is cleared |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Follow-up to #2937, where I've responded to some comments that myself and others have left in order to clarify certain functionality.
Note on structure: The
legacy-handlerssubdriver is nearly untouched from before- the only real difference is that the key-we logic was lifted out from there since it is so close in from to the "new", now default key-we overriden behavior.The other primary thing that was removed from the now-
legacy-handlerssubdriver is the oldaddedhandler, for the following 2 reasons. 1. Generally, devices should not be added to this driver any longer, and 2. We now use theaddedmain driver implementation to initially set the migrated keyword totrue.I find the fact that the entire migrated state depends on a keyword set only once in
addedto be a little precarious, but nothing stands out to me initially at this not working.Summary of Completed Tests