Hugo Config option for blog URLs: avoid deprecation by olleolleolle · Pull Request #2439 · SeleniumHQ/seleniumhq.github.io

olleolleolle · 2025-08-20T15:05:54Z

User description

Description

This PR avoids a warning emitted by latest Hugo at start of generating the website.

Motivation and Context

We want to follow current Hugo practices, to have a working website.

WARN  deprecated: the ":filename" permalink token was deprecated in Hugo 0.144.0 and will be removed in a future release. Use ":contentbasename" instead.

Update: hugo v0.125.4 is running in the GitHub Action. So that doesn't have support for that feature yet.

Now https://github.com/peaceiris/actions-hugo?tab=readme-ov-file#options CAN configure a newer one.

Update: I chose to update to latest Hugo in the jobs that required a newer one.

TODO

Avoid GetJSON, and follow the error message. Usages: https://github.com/search?q=repo%3ASeleniumHQ%2Fseleniumhq.github.io%20GetJSON&type=code 12:02:55 PM: ERROR deprecated: data.GetJSON was deprecated in Hugo v0.123.0 and subsequently removed. use resources.Get or resources.GetRemote with transform.Unmarshal. Hints in this help article - https://discourse.gohugo.io/t/how-to-replace-the-data-getjson-with-resources-getremote-or-resources-get/52728/4

Types of changes

Change to the site (I have double-checked the Netlify deployment, and my changes look good)

Checklist

I have read the contributing document.
I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Other

Description

Replace deprecated :filename with :contentbasename in Hugo permalinks

Diagram Walkthrough

flowchart LR
  A["Hugo Config"] -- "update permalink" --> B["Replace :filename"] -- "with" --> C[":contentbasename"]

File Walkthrough

Relevant files

Configuration changes

hugo.toml `Update Hugo permalink configuration` website_and_docs/hugo.toml Replace deprecated `:filename` token with `:contentbasename` in blog permalinks configuration	+1/-1

WARN deprecated: the ":filename" permalink token was deprecated in Hugo 0.144.0 and will be removed in a future release. Use ":contentbasename" instead.

netlify · 2025-08-20T15:06:00Z

✅ Deploy Preview for selenium-dev ready!

Name	Link
🔨 Latest commit	`1d5ffde`
🔍 Latest deploy log	https://app.netlify.com/projects/selenium-dev/deploys/68ac55a1fa9bc8000847d282
😎 Deploy Preview	https://deploy-preview-2439--selenium-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

qodo-code-review · 2025-08-20T15:06:15Z

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review URL Compatibility Changing from :filename to :contentbasename may alter generated URLs for posts where filename differs from slug or where multilingual/content structure affects basenames. Verify that existing links, redirects, and RSS entries remain valid. blog = "/:section/:year/:contentbasename/" # blog = "/:section/:year/:month/:day/:slug/"

qodo-code-review · 2025-08-20T15:06:37Z

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Use a widely-supported token Ensure the permalink token matches your Hugo version. In Hugo v0.55+ the replacement for :filename is :slug or using :path components; :contentbasename is only valid in newer Hugo versions. If your build runs on mixed or older versions, use a safer, widely-supported token to avoid broken links. website_and_docs/hugo.toml [30] -blog = "/:section/:year/:contentbasename/" +blog = "/:section/:year/:slug/" Apply / Chat Suggestion importance[1-10]: 7 __ Why: The suggestion correctly raises a valid concern about Hugo version compatibility, as the `:contentbasename` token is newer and might not be supported in all build environments, proposing a safer alternative.	Medium
Update

diemol

It seems the build is failing.

olleolleolle · 2025-08-21T07:40:30Z

In order to have a Hugo that supports the current way of expression, I set hugo-version to the current release in the CI jobs I could find. cc @diemol

diemol

Thank you for this.

However, there are other places where version 0.125.4 is set. Like the netlify.toml file.

olleolleolle · 2025-08-21T09:57:25Z

I learned that there were a few more places. In situations like this, I often write a script/update_hugo_version shell script (perhaps in Ruby or something that is convenient for me) that updates all the places.

diemol · 2025-08-21T10:07:38Z

This is the error the Netlify build reports. I am not sure why the GitHub Actions build does not report the same.

12:02:50 PM: Start building sites …
12:02:50 PM: hugo v0.148.2-40c3d8233d4b123eff74725e5766fc6272f0a84d+extended linux/amd64 BuildDate=2025-07-27T12:43:24Z VendorInfo=gohugoio
12:02:50 PM: WARN  skipping template file "/opt/build/cache/hugo_cache/modules/filecache/modules/pkg/mod/github.com/google/[email protected]/layouts/_default/_markup/td-render-heading.html": unrecognized render hook template
12:02:53 PM: WARN  The "gist" shortcode was deprecated in v0.143.0 and will be removed in a future release. See https://gohugo.io/shortcodes/gist for instructions to create a replacement.
12:02:55 PM: WARN  The "twitter", "tweet", and "twitter_simple" shortcodes were deprecated in v0.142.0 and will be removed in a future release. Please use the "x" shortcode instead.
12:02:55 PM: ERROR deprecated: data.GetJSON was deprecated in Hugo v0.123.0 and subsequently removed. use resources.Get or resources.GetRemote with transform.Unmarshal.

olleolleolle · 2025-08-21T10:16:09Z

@diemol There is a concept of “extended Hugo”, perhaps that has a different set of available commands/a different deprecation schedule. On my local macOS brew install, I got the warning about twitter, but not the error there.

diemol · 2025-08-21T10:29:58Z

I think the problem is this one:

12:02:55 PM: ERROR deprecated: data.GetJSON was deprecated in Hugo v0.123.0 and subsequently removed. use resources.Get or resources.GetRemote with transform.Unmarshal.

Yes, we use extended Hugo, because Docsy requires it.

I looked at https://discourse.gohugo.io/t/how-to-replace-the-data-getjson-with-resources-getremote-or-resources-get/52728/4 to learn a little about how to do it.

olleolleolle · 2025-08-25T12:23:22Z

@diemol I attempted to make a change, can you "approve the CI build"?

diemol

Thank you!

* Hugo Config option for blog URLs: avoid deprecation WARN deprecated: the ":filename" permalink token was deprecated in Hugo 0.144.0 and will be removed in a future release. Use ":contentbasename" instead. * Refer to latest Hugo release * Hugo: stop using getJSON I looked at https://discourse.gohugo.io/t/how-to-replace-the-data-getjson-with-resources-getremote-or-resources-get/52728/4 to learn a little about how to do it. --------- Co-authored-by: Diego Molina <[email protected]> [deploy site] 7baeff3

Hugo Config option for blog URLs: avoid deprecation

b0811ba

WARN deprecated: the ":filename" permalink token was deprecated in Hugo 0.144.0 and will be removed in a future release. Use ":contentbasename" instead.

qodo-code-review Bot added the Review effort 1/5 label Aug 20, 2025

diemol reviewed Aug 20, 2025

View reviewed changes

diemol reviewed Aug 21, 2025

View reviewed changes

Refer to latest Hugo release

b2948d0

olleolleolle force-pushed the use-current-hugo-config-for-filename branch from e4cfddc to b2948d0 Compare August 21, 2025 09:56

Merge branch 'trunk' into use-current-hugo-config-for-filename

d050a10

olleolleolle added 2 commits August 25, 2025 14:22

Hugo: stop using getJSON

f7dc8d6

I looked at https://discourse.gohugo.io/t/how-to-replace-the-data-getjson-with-resources-getremote-or-resources-get/52728/4 to learn a little about how to do it.

Merge branch 'trunk' into use-current-hugo-config-for-filename

1d5ffde

diemol approved these changes Aug 28, 2025

View reviewed changes

diemol merged commit 7baeff3 into SeleniumHQ:trunk Aug 28, 2025
6 checks passed

olleolleolle deleted the use-current-hugo-config-for-filename branch August 28, 2025 09:01

Uh oh!

Conversation

olleolleolle commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User description

Description

Motivation and Context

TODO

Types of changes

Checklist

PR Type

Description

Diagram Walkthrough

File Walkthrough

Uh oh!

netlify Bot commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for selenium-dev ready!

Uh oh!

qodo-code-review Bot commented Aug 20, 2025

PR Reviewer Guide 🔍

Uh oh!

qodo-code-review Bot commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Code Suggestions ✨

Uh oh!

diemol left a comment

Choose a reason for hiding this comment

Uh oh!

olleolleolle commented Aug 21, 2025

Uh oh!

diemol left a comment

Choose a reason for hiding this comment

Uh oh!

olleolleolle commented Aug 21, 2025

Uh oh!

diemol commented Aug 21, 2025

Uh oh!

olleolleolle commented Aug 21, 2025

Uh oh!

diemol commented Aug 21, 2025

Uh oh!

olleolleolle commented Aug 25, 2025

Uh oh!

diemol left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

olleolleolle commented Aug 20, 2025 •

edited

Loading

netlify Bot commented Aug 20, 2025 •

edited

Loading

qodo-code-review Bot commented Aug 20, 2025 •

edited

Loading