You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for contributing to the Selenium site and documentation! A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
fixing bug 2402, detectify link removal
Description
fixing bug 2402, detectify link removal. removed the link, mentioned whole name of company, and we want user to directly go see the blog which is on their website. So that solves the purpose.
Motivation and Context
Bug 2404
Types of changes
Change to the site (I have double-checked the Netlify deployment, and my changes look good)
Code example added (and I also added the example to all translated languages)
Improved translation
Added new translation (and I also added a notice to each document missing translation)
The sentence structure is awkward with the colon placement. The text reads "See this blog post on Detectify Labs, which gives a good overview of how a publicly exposed Grid could be misused:" followed by the link on the next line, creating an unnatural break.
See this blog post on Detectify Labs, which gives a good overview of how a publicly exposed Grid could be misused:
[Don't Leave your Grid Wide Open](//labs.detectify.com/2017/10/06/guest-blog-dont-leave-your-grid-wide-open/).
The comma placement after "Detectify Labs," appears incorrect in Japanese context and creates awkward sentence flow when combined with the following text.
Why: The suggestion correctly identifies that the comma after Detectify Labs is grammatically incorrect in the Japanese sentence, and removing it improves readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
fixing bug 2402, detectify link removal
Description
fixing bug 2402, detectify link removal. removed the link, mentioned whole name of company, and we want user to directly go see the blog which is on their website. So that solves the purpose.
Motivation and Context
Bug 2404
Types of changes
Checklist
PR Type
Documentation
Description
Remove hyperlink from Detectify reference in Grid documentation
Replace linked text with plain text "Detectify Labs"
Update formatting and punctuation across multiple language versions
Diagram Walkthrough
File Walkthrough
getting_started.en.md
Remove Detectify hyperlink in English docswebsite_and_docs/content/documentation/grid/getting_started.en.md
getting_started.ja.md
Remove Detectify hyperlink in Japanese docswebsite_and_docs/content/documentation/grid/getting_started.ja.md
getting_started.pt-br.md
Remove Detectify hyperlink in Portuguese docswebsite_and_docs/content/documentation/grid/getting_started.pt-br.md
getting_started.zh-cn.md
Remove Detectify hyperlink in Chinese docswebsite_and_docs/content/documentation/grid/getting_started.zh-cn.md