You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for contributing to the Selenium site and documentation! A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
removed event details
Description
removed event details
Motivation and Context
removed event details
Types of changes
Change to the site (I have double-checked the Netlify deployment, and my changes look good)
Code example added (and I also added the example to all translated languages)
Improved translation
Added new translation (and I also added a notice to each document missing translation)
The alert div now contains only whitespace, which may render an empty banner on the site. Consider removing the entire banner section or adding conditional rendering to avoid displaying empty content.
The empty alert div with styling classes serves no purpose and creates unnecessary DOM elements. Since the banner flags are disabled in the config, this entire section should be removed or the content should be properly cleaned up.
<div class="alert alert-{{ $color }} col-12 fade show mb-0 p-0 -bg-{{ $color }}" role="alert">
-+ <!-- Event announcement content will be added here when needed -->
</div>
Apply / Chat
Suggestion importance[1-10]: 4
__
Why: The suggestion correctly identifies that the PR leaves an empty div, and adding a comment as proposed improves maintainability by clarifying the element's purpose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
removed event details
Description
removed event details
Motivation and Context
removed event details
Types of changes
Checklist
PR Type
Other
Description
Removed Selenium Community Live event announcement banner
Disabled announcement banner functionality in site configuration
Diagram Walkthrough
File Walkthrough
announcement-banner.html
Remove event announcement contentwebsite_and_docs/layouts/partials/announcement-banner.html
hugo.toml
Disable announcement banner flagswebsite_and_docs/hugo.toml
banner_flagfrom true to falseannouncement_bannerfrom true to false