You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for contributing to the Selenium site and documentation! A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Change to the site (I have double-checked the Netlify deployment, and my changes look good)
Code example added (and I also added the example to all translated languages)
Improved translation
Added new translation (and I also added a notice to each document missing translation)
All test methods in this class are annotated with @ignore but the class itself is not. Consider adding a comment explaining why these tests are ignored or remove the annotation if they should be executed.
The test uses a hardcoded URL for the Selenium Grid (http://localhost:4444). Consider making this configurable through a property or environment variable to improve flexibility.
Replace the deprecated setCapability("webSocketUrl", true) with options.enableBiDi() which is the recommended way to enable BiDi protocol support in Selenium 4.
FirefoxOptions options = new FirefoxOptions();
-options.setCapability("webSocketUrl", true);+options.enableBiDi();
options.addArguments("-private");
Apply this suggestion
Suggestion importance[1-10]: 8
__
Why: The suggestion correctly identifies the use of a deprecated method setCapability("webSocketUrl", true) and proposes replacing it with the recommended options.enableBiDi() method. This is an important improvement for code maintainability and future compatibility with Selenium 4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
Tests
Description
Added multiple test classes for parallel browser instance testing.
MultipleInstanceParallelTesttests background color changes using multiple browser instances.SingleInstanceCookieParallelTesttests background color changes using a single browser instance with user context.SingleInstanceCookieParallelGridTesttests similar functionality on a Selenium Grid setup.Demonstrated the use of WebDriver BiDi API for user context and browsing context management.
Included assertions for verifying background color changes and default states.
Changes walkthrough 📝
MultipleInstanceParallelTest.java
Add tests for multiple browser instance parallel testingexamples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/user_context/MultipleInstanceParallelTest.java
instances.
SingleInstanceCookieParallelTest.java
Add tests for single browser instance with user contextexamples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/user_context/SingleInstanceCookieParallelTest.java
instance.
SingleInstanceCookieParallelGridTest.java
Add Selenium Grid tests for single browser instanceexamples/java/src/test/java/dev/selenium/bidirectional/webdriver_bidi/user_context/SingleInstanceCookieParallelGridTest.java
WebDriver.
@Ignoreannotations for tests, likely for future enablement.