Add BiDi network examples and documentation for Ruby#2100
Add BiDi network examples and documentation for Ruby#2100diemol merged 13 commits intoSeleniumHQ:trunkfrom
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
…' into rb_add_network_examples_and_docs # Conflicts: # examples/ruby/Gemfile
|
@aguspe, what is missing in this PR? |
|
@diemol now it will be ready to merge, but I noticed some issues with other examples outside of this PR, so I'm waiting to see if my changes fixed them so the Ruby pipeline is green again |
harsha509
left a comment
There was a problem hiding this comment.
LGTM,
re-ran failed test, waiting for CI to pass ✅
|
@aguspe can you also create issues and tag them as needs translation based on the changes made in this PR? |
|
Absolutely @harsha509 i will do that tomorrow😊 |
|
Can you please skip the IE tests? I believe we don't have the binary present in GH runners anymore. |
no problem, I just pushed the changes now, I will need a re-review @harsha509 thank you! |
User description
Description
This PR adds documentation for the work done in #13993
And it also adds examples for the upcoming Response handler method
Motivation and Context
To facilitate use and adoption of the new BiDi implementation is important that the documentation is up to date with relevant examples
Types of changes
Checklist
PR Type
Documentation, Enhancement
Description
Changes walkthrough 📝
network_spec.rb
Add BiDi network handler tests for Rubyexamples/ruby/spec/bidi/network_spec.rb
network.en.md
Add BiDi network handlers documentation with Ruby exampleswebsite_and_docs/content/documentation/webdriver/bidi/network.en.md
handlers
network.ja.md
Update Japanese translation with BiDi network documentationwebsite_and_docs/content/documentation/webdriver/bidi/network.ja.md
network.pt-br.md
Update Portuguese translation with BiDi network documentationwebsite_and_docs/content/documentation/webdriver/bidi/network.pt-br.md
network.zh-cn.md
Update Chinese translation with BiDi network documentationwebsite_and_docs/content/documentation/webdriver/bidi/network.zh-cn.md