You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for contributing to the Docker-Selenium project! A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
The PR changes FFMPEG_VERSION from 7.1.1 to 7.1, which appears to be a downgrade. However, FFMPEG_TAG_VERSION is changed from ffmpeg-7.1.1.1.1 to ffmpeg-7.1. Verify if this version change is intentional and consistent with project requirements.
The PR adds explicit version pinning for JWT libraries. Verify that the specified versions (v4.5.2 and v5.2.2) are the appropriate versions needed for security and compatibility with the rest of the codebase.
There's a version inconsistency between the FFmpeg variables. The FFMPEG_TAG_PREV_VERSION is set to 7.1.1.1 while the other variables use 7.1. This inconsistency could cause build or versioning issues.
Why: The suggestion correctly identifies an important version inconsistency between FFmpeg variables. Aligning FFMPEG_TAG_PREV_VERSION with the other variables (changing from 7.1.1.1 to 7.1) ensures consistent versioning, which is critical for proper build functionality and version tracking.
Medium
More
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement, Configuration changes
Description
Updated FFmpeg version and related tags in
Makefile.Added new Go module versions for JWT libraries in
.ffmpeg/Dockerfile.Patched Go dependencies in
rcloneto address CVEs.Improved configuration for FFmpeg image build process.
Changes walkthrough 📝
Dockerfile
Add JWT library versions and patch Go dependencies.ffmpeg/Dockerfile
go.modpatching to include JWT libraries.rclonebuild process with updated dependencies.Makefile
Update FFmpeg version and tag configurationsMakefile
7.1.