Skip to content

Add missing settings from settings link list #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
7w1 wants to merge 1 commit into
base: dev
Choose a base branch
from
+25 −0
Open

Add missing settings from settings link list #765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/readd-missing-settings.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
default: patch
---

Readded various missing settings from the settings sharing list.
6 changes: 6 additions & 0 deletions src/app/features/settings/settingsLink.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ describe('settingsLink', () => {
'https://app.example/settings/appearance/?focus=message-link-preview'
)
).toEqual({ section: 'appearance', focus: 'message-link-preview' });
expect(
parseSettingsLink(
'https://app.example',
`https://app.example/settings/general?focus=composer-formatting-toolbar&${SETTINGS_LINK_ACTION_PARAM}=${SETTINGS_LINK_ACTION_SETTINGS}`
)
).toEqual({ section: 'general', focus: 'composer-formatting-toolbar' });
expect(
parseSettingsLink(
'https://app.example',
Expand Down
14 changes: 14 additions & 0 deletions src/app/features/settings/settingsLink.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,12 @@ const settingsSectionLabel = Object.fromEntries(
const settingsLinkFocusIdsBySection: Record<SettingsSectionId, readonly string[]> = {
general: [
'client-side-embeds',
'composer-formatting-toolbar',
'custom-date-format',
'date-format',
'disable-media-auto-load',
'display-bundled-embeds',
'display-multiple-embeds',
'embed-youtube-links',
'emoji-selector-threshold',
'enable-swiping',
Expand Down Expand Up @@ -61,6 +63,7 @@ const settingsLinkFocusIdsBySection: Record<SettingsSectionId, readonly string[]
'email-address',
'has-cats',
'is-cat',
'user-hero-color',
'matrix-id',
'name-color',
'name-color-dark-theme',
Expand All @@ -85,13 +88,24 @@ const settingsLinkFocusIdsBySection: Record<SettingsSectionId, readonly string[]
'collapse-folders-by-default',
'colorful-names',
'consistent-icon-style',
'browse-remote-catalog',
'customize-dm-cards',
'custom-profile-cards',
'dark-theme',
'jumbo-emoji-size',
'light-theme',
'manual-theme',
'message-link-preview',
'page-zoom',
'catalog-themes',
'catalog-tweaks',
'theme-browse-remote',
'theme-catalog-clear-remote',
'theme-chat-sable-widgets',
'theme-chat-auto-approved',
'theme-chat-auto-any',
'theme-import-open',
'theme-local-sync-system',
'pronoun-pills-for-all',
'reduced-motion',
'render-global-username-colors',
Expand Down
Loading