-
Notifications
You must be signed in to change notification settings - Fork 407
fix: secure SSR cache key generation against untrusted headers #21383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
l3tchupkt
wants to merge
2
commits into
SAP:develop
Choose a base branch
from
l3tchupkt:fix/secure-ssr-cache-key
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
67 changes: 67 additions & 0 deletions
67
core-libs/setup/ssr/express-utils/express-request-safe-host.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| /* | ||
| * SPDX-FileCopyrightText: 2026 SAP Spartacus team <[email protected]> | ||
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| import { Request } from 'express'; | ||
|
|
||
| /** | ||
| * Returns a trusted host from the request object. | ||
| * | ||
| * It first checks the `X-Forwarded-Host` header and returns it only if it is valid | ||
| * and matches the `allowedHosts` list. If `X-Forwarded-Host` is missing, invalid, | ||
| * or not allowlisted, it then checks the `Host` header and returns it only if it is | ||
| * also valid and allowlisted. | ||
| * | ||
| * If neither header passes validation and allowlist checks, this function returns | ||
| * `undefined`, and callers should treat that as "no trusted host". | ||
| * | ||
| * @param req - Express Request object | ||
| * @param allowedHosts - Optional list of allowed hosts | ||
| */ | ||
| export function getSafeHost(req: Request, allowedHosts?: string[]): string | undefined { | ||
| const normalize = (h: string): string => | ||
| h.toLowerCase().split(':')[0].replace(/\.$/, '').trim(); | ||
|
|
||
| const isValidHost = (h: string): boolean => | ||
| h.length > 0 && | ||
| h.length <= 255 && | ||
| /^[a-z0-9]([a-z0-9-]*[a-z0-9])?(\.[a-z0-9]([a-z0-9-]*[a-z0-9])?)*$/.test(h); | ||
|
|
||
| const normalizedAllowedHosts = allowedHosts?.map(normalize); | ||
|
|
||
| const isAllowed = (host: string, normalizedAllowed?: string[]): boolean => { | ||
| return normalizedAllowed?.some((allowed) => host === allowed) ?? false; | ||
| }; | ||
|
|
||
| const extractFirst = (value?: string | string[]): string | undefined => { | ||
| if (!value) { | ||
| return undefined; | ||
| } | ||
| const v = Array.isArray(value) ? value[0] : value; | ||
| return v.split(',')[0].trim(); | ||
| }; | ||
|
|
||
| const xfHostRaw = extractFirst(req.headers['x-forwarded-host']); | ||
| const hostRaw = extractFirst(req.headers.host); | ||
|
|
||
| const xfHost = xfHostRaw ? normalize(xfHostRaw) : undefined; | ||
| const host = hostRaw ? normalize(hostRaw) : undefined; | ||
|
|
||
| // Validate X-Forwarded-Host | ||
| if ( | ||
| xfHost && | ||
| isValidHost(xfHost) && | ||
| isAllowed(xfHost, normalizedAllowedHosts) | ||
| ) { | ||
| return xfHost; | ||
| } | ||
|
|
||
| // Validate Host | ||
| if (host && isValidHost(host) && isAllowed(host, normalizedAllowedHosts)) { | ||
| return host; | ||
| } | ||
|
|
||
| return undefined; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.