Draft
Conversation
…uired web API polyfills
…t/support-eslint-10
- examples/fe-fpm-cli: take mains newer @types/vinyl and typescript-eslint - examples/ui-prompting-examples: take mains css-loader 7.1.4, keep eslint 9.39.1 (React package) - package.json: keep eslint 10.0.3 from PR; take mains newer @types/node, esbuild, typescript-eslint - eslint-plugin-fiori-tools: peerDep eslint set to >=9 (supports both 9 and 10) - eslint-plugin-fiori-tools/src/index.ts: keep fioriRules alias in both config exports - preview-middleware-client/eslint.config.js: take mains corrected tseslint.plugin/parser usage
Candidate 1 mta-config refactor files and RFC docs were accidentally committed during the main merge. They belong on a separate refactor/cf-deploy-config-mta-god-class branch.
…or Jest moduleNameMapper
- sap-no-override-rendering: add valid/invalid cases with custom ns options to cover the context.options[0]?.ns ternary branch - create-table-custom-column-config-change: add test for findAnchor() IIFE branch when metaPath does not contain 'LineItem', triggering getLineItemAnnotation() to compute the annotation path
🦋 Changeset detectedLatest commit: 0acad1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 83 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![hyperspace-insights[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Support ESLint 10 and Relax Dependency Version Ranges Across Monorepo
New Features
✨ ESLint 10 support for
@sap-ux/eslint-plugin-fiori-tools: The plugin now declareseslint: "^9 || ^10"as a peer dependency and has been updated internally to be compatible with ESLint 10. This is a major version bump for the plugin package.All generated Fiori app/library project templates that include ESLint configuration are updated to reference
eslint: "^10"and@sap-ux/eslint-plugin-fiori-tools: "^10.0.0".♻️ Caret ranges for all runtime
dependencies: Every exact-pinned version (e.g."2.1.0") across the entire monorepo has been converted to a caret range (e.g."^2.1.0"). This follows npm best practice — exact pins in published packages unnecessarily restrict consumers and can cause duplicate installs or version conflicts. The pnpm lockfile continues to guarantee reproducible installs.Changes
packages/eslint-plugin-fiori-tools/package.json: Updated peer dep toeslint: "^9 || ^10", bumped@eslint/js,@eslint/core,@eslint/plugin-kit, moved@types/semvertodevDependencies, and converted all deps to caret ranges.packages/eslint-plugin-fiori-tools/src/index.ts: Extracted sharedfioriRulesvariable to avoid repeated type assertions.packages/eslint-plugin-fiori-tools/src/rules/*.ts: Removed deprecatedcategory: 'Best Practices'field from all ruledocsmetadata (not supported in ESLint 10).packages/eslint-plugin-fiori-tools/src/rules/sap-no-global-variable.ts,sap-no-override-rendering.ts,sap-ui5-no-private-prop.ts,sap-usage-basemastercontroller.ts: Removed deprecatedcontext.getSourceCode()fallback; now usescontext.sourceCodedirectly (required by ESLint 10).packages/eslint-plugin-fiori-tools/src/types.ts: RenamedFioriRuleDefinitiontoFioriRuleDefinitionInternaland introduced a newFioriRuleDefinitiontype that intersects with ESLint'sRuleDefinitionfor ESLint 10 compatibility.packages/eslint-plugin-fiori-tools/src/language/*/types.ts: MovedCustomRuleDefinitionType/CustomRuleTypeDefinitionsimports from@eslint/coreto@eslint/plugin-kit(API reorganization between versions).packages/eslint-plugin-fiori-tools/test/rules/*.test.ts: Removedtypeassertions from all error test cases (no longer required/supported in ESLint 10'sRuleTester).packages/app-config-writer/src/eslint-config/convert.ts: Updated default ESLint version written to generatedpackage.jsonfrom^9.0.0to^10.0.0.packages/ui5-application-writer/templates/optional/eslint/package.json,packages/ui5-library-writer/templates/optional/typescript/package.json: Template ESLint references bumped to^10.package.json(root): Bumpedeslintfrom9.39.1to^10.0.3and@eslint/jsto^10.0.1for monorepo tooling..nvmrc: Added Node version pin20.20.0.AGENTS.md: Added documentation rule requiring caret ranges for runtimedependenciesand summarized version range rules bydependencies/devDependencies/peerDependencies.package.jsonfiles across the monorepo: Converted exact-pinned versions to caret ranges in bothdependenciesanddevDependencies..changeset/fair-adults-cheat.md: Changeset for ESLint 10 support..changeset/chore-relax-dependency-version-ranges.md: Changeset for the dependency range relaxation.PR Bot Information
Version:
1.20.23anthropic--claude-4.6-sonnet1688d78d-393a-47c1-b491-cbef321eb4ccpull_request.opened