reusable xml id validation method

[Jimmy-Joseph19]

Add validateId method to project-access for reusability across multiple packages

[changeset-bot]

🦋 Changeset detected

Latest commit: f8e83d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 52 packages

Name	Type
@sap-ux/project-access	Patch
@sap-ux/fe-fpm-writer	Patch
@sap-ux/abap-deploy-config-sub-generator	Patch
@sap-ux/abap-deploy-config-writer	Patch
@sap-ux/adp-flp-config-sub-generator	Patch
@sap-ux/adp-tooling	Patch
@sap-ux/annotation-generator	Patch
@sap-ux/app-config-writer	Patch
@sap-ux/cap-config-writer	Patch
@sap-ux/cf-deploy-config-sub-generator	Patch
@sap-ux/cf-deploy-config-writer	Patch
@sap-ux/create	Patch
@sap-ux/deploy-config-sub-generator	Patch
@sap-ux/environment-check	Patch
@sap-ux/eslint-plugin-fiori-tools	Patch
@sap-ux/fiori-annotation-api	Patch
@sap-ux/fiori-app-sub-generator	Patch
@sap-ux/fiori-elements-writer	Patch
@sap-ux/fiori-generator-shared	Patch
@sap-ux/flp-config-inquirer	Patch
@sap-ux/flp-config-sub-generator	Patch
@sap-ux/generator-adp	Patch
@sap-ux/inquirer-common	Patch
@sap-ux/launch-config	Patch
@sap-ux/mockserver-config-writer	Patch
@sap-ux/odata-service-inquirer	Patch
@sap-ux/odata-service-writer	Patch
@sap-ux/preview-middleware	Patch
@sap-ux/project-input-validator	Patch
@sap-ux/project-integrity	Patch
@sap-ux/repo-app-import-sub-generator	Patch
@sap-ux/telemetry	Patch
@sap-ux/ui5-application-inquirer	Patch
@sap-ux/ui5-library-reference-inquirer	Patch
@sap-ux/ui5-library-reference-sub-generator	Patch
@sap-ux/ui5-library-reference-writer	Patch
@sap-ux/ui5-library-writer	Patch
@sap-ux/ui5-test-writer	Patch
@sap-ux-private/adaptation-editor-tests	Patch
@sap-ux/fe-fpm-cli	Patch
@sap-ux/backend-proxy-middleware-cf	Patch
@sap-ux/fiori-freestyle-writer	Patch
@sap-ux-private/preview-middleware-client	Patch
@sap-ux/abap-deploy-config-inquirer	Patch
@sap-ux/deploy-config-generator-shared	Patch
@sap-ux/ui-service-sub-generator	Patch
@sap-ux/ui5-library-sub-generator	Patch
@sap-ux/cf-deploy-config-inquirer	Patch
@sap-ux/deploy-tooling	Patch
@sap-ux/ui-service-inquirer	Patch
@sap-ux/ui5-library-inquirer	Patch
@sap-ux/generator-simple-fe	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[hyperspace-insights]

Summary

The following content is AI-generated and provides a summary of the pull request:

---

Add Reusable validateId Method to project-access

New Feature

✨ Introduces a reusable validateId function in @sap-ux/project-access that checks whether an XML element ID is unique across view and fragment files. This consolidates duplicate ID-checking logic previously scattered across packages.

The new function supports two overloads:

• Synchronous: when XML file contents are provided directly as strings
• Asynchronous: when an appPath is provided to scan the filesystem for .view.xml and .fragment.xml files (with optional mem-fs-editor support)

Changes

• packages/project-access/src/library/helpers.ts: Added the validateId function with synchronous and asynchronous overloads. Uses fast-xml-parser for XML parsing and recursively searches for element IDs. Also added findFilesByExtension and mem-fs-editor imports.
• packages/project-access/src/library/index.ts: Exported validateId from the library index.
• packages/fe-fpm-writer/src/common/file.ts: Replaced the local checkElementIdAvailable implementation (which used @xmldom/xmldom's DOMParser) with a call to the new shared validateId from @sap-ux/project-access, removing the DOMParser dependency.
• packages/project-access/test/library/helpers.test.ts: Added a comprehensive validateId test suite covering ID existence checks in views and fragments, nested elements, empty files, invalid XML, special character IDs, and the validatedIds exclusion list.

---

• 🔄 Regenerate and Update Summary
• ✏️ Insert as PR Description (deletes this comment)
• 🗑️ Delete comment

PR Bot Information

Version: 1.20.23

• Summary Prompt: Default Prompt
• Output Template: Default Template
• LLM: anthropic--claude-4.6-sonnet
• File Content Strategy: Full file content
• Correlation ID: 7f6ca6b8-428f-40f7-98e5-7d6cd51dc3ef
• Event Trigger: pull_request.opened

[hyperspace-insights]

The PR introduces a useful validateId abstraction in @sap-ux/project-access, but has a critical correctness bug in the async path: findFilesByExtension returns file paths, not file contents, so the XML parser receives path strings instead of XML and ID collision detection never fires when appPath is used. There are also secondary issues: a dead-code assignment in the async IIFE (fileContents is always undefined there), and the synchronous-overload tests are all async/await which silently masks whether the synchronous contract is actually being exercised.

PR Bot Information

Version: 1.20.23

• LLM: anthropic--claude-4.6-sonnet
• File Content Strategy: Full file content
• Agent Instructions:
  • AGENTS.md
  • CLAUDE.md
• Correlation ID: 7f6ca6b8-428f-40f7-98e5-7d6cd51dc3ef
• Event Trigger: pull_request.opened

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[815are]

checked code:

1. code changes are easy to understand and approach to use fast-xml-parser instead of xmldom/xmldom
2. changelog persists
3. I did not test manually