Skip to content

feat: add Claude Code plugin support#4575

Open
mustafamengutay-sap wants to merge 13 commits intomainfrom
feat/add-claude-plugin
Open

feat: add Claude Code plugin support#4575
mustafamengutay-sap wants to merge 13 commits intomainfrom
feat/add-claude-plugin

Conversation

@mustafamengutay-sap
Copy link
Copy Markdown
Contributor

@mustafamengutay-sap mustafamengutay-sap commented Apr 20, 2026

This PR registers the Fiori MCP Server as a plugin in the Claude Code plugin registry for enabling users to find and install it directly from within Claude Code.

Changes

Adds plugin.json, the Claude Code plugin registry manifest. Defines the plugin name, description, author, homepage, repository, license, keywords, and version so the server appears in Claude Code's plugin discovery UI.

Adds .mcp.json at the package root. This file is automatically picked up by Claude Code when the plugin is enabled, starting the MCP server via npx.

Adds AGENTS.mddocumenting the purpose of server.json, plugin.json, .mcp.json, or AI coding agents and contributors working on this package.

Extends sync-mcp-manifests.js (formerly sync-mcp-server-json.js), so all manifest files stay in sync automatically after changeset version bumps via the CI pipeline.

@mustafamengutay-sap mustafamengutay-sap requested review from a team as code owners April 20, 2026 08:18
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 20, 2026

🦋 Changeset detected

Latest commit: e972460

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/fiori-mcp-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Contributor

@hyperspace-insights hyperspace-insights Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is well-structured and achieves its goal of adding Claude Code plugin support cleanly. The two issues flagged are: a minor inaccuracy in the AGENTS.md documentation describing the homepage field, and a missing error-handling block in the sync script that could produce cryptic CI failures if any manifest file is absent or malformed.

PR Bot Information

Version: 1.20.11 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback

  • Agent Instructions:
  • LLM: anthropic--claude-4.6-sonnet
  • Event Trigger: pull_request.opened
  • File Content Strategy: Full file content
  • Correlation ID: 357e5ed1-06be-42e5-b822-524e5a5d1709

Comment thread packages/fiori-mcp-server/AGENTS.md Outdated
Comment thread packages/fiori-mcp-server/scripts/sync-mcp-manifests.js Outdated
@hyperspace-insights

This comment was marked as duplicate.

@heimwege heimwege added the fiori-mcp @sap-ux/fiori-mcp label Apr 20, 2026
Copy link
Copy Markdown
Contributor

@heimwege heimwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit-pick comment.

Comment thread packages/fiori-mcp-server/scripts/sync-mcp-manifests.js Outdated
Comment thread packages/fiori-mcp-server/scripts/sync-mcp-manifests.js Outdated
Copy link
Copy Markdown
Contributor

@heimwege heimwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • review comments addressed
  • changeset ok
  • coverage ok
  • did NOT test manually

vinayhospete
vinayhospete previously approved these changes Apr 22, 2026
@vinayhospete
Copy link
Copy Markdown
Member

New proposal to move the plugin out of the MCP server to a more generic plugin like "plugins/SAP-Fiori-tools"

@sonarqubecloud
Copy link
Copy Markdown

@vinayhospete vinayhospete dismissed their stale review April 22, 2026 12:04

New proposal to move plugin out of MCP server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fiori-mcp @sap-ux/fiori-mcp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants