Feat: add sap-description-column-label ESLint rule#4542
Open
marcovieth wants to merge 20 commits intomainfrom
Open
Feat: add sap-description-column-label ESLint rule#4542marcovieth wants to merge 20 commits intomainfrom
marcovieth wants to merge 20 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 5d8bc7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lfindlaysap
requested changes
Apr 15, 2026
lfindlaysap
requested changes
Apr 15, 2026
Contributor
lfindlaysap
left a comment
lfindlaysap
left a comment
There was a problem hiding this comment.
Here are my suggestions.
lfindlaysap
requested changes
Apr 21, 2026
| `trivialLabel`: The `Common.Label` annotation on the text property is too generic: | ||
|
|
||
| ```xml | ||
| <!-- ProductBaseUnit uses UnitOfMeasure_Text as its description column via Common.Text annotation --> |
Contributor
There was a problem hiding this comment.
Suggested change
| <!-- ProductBaseUnit uses UnitOfMeasure_Text as its description column via Common.Text annotation --> | |
| <!-- ProductBaseUnit uses UnitOfMeasure_Text as its description column using the Common.Text annotation --> |
… the rule documentation
|
…ommon.Text annotation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that the property referenced as the description (text) value via
Common.Texthas a meaningfulCommon.Label-- not a generic value such as"Name"or"Description", and not the same label as the ID property it describes.