fix(deploy-tooling): prevent cleartext credentials in deploy configuration#4539
Open
fix(deploy-tooling): prevent cleartext credentials in deploy configuration#4539
Conversation
🦋 Changeset detectedLatest commit: 923a93d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lfindlaysap
requested changes
Apr 10, 2026
Co-authored-by: Louise Findlay <[email protected]>
lfindlaysap
previously approved these changes
Apr 10, 2026
mikicvi-SAP
previously approved these changes
Apr 14, 2026
Contributor
mikicvi-SAP
left a comment
mikicvi-SAP
left a comment
There was a problem hiding this comment.
Thanks @longieirl
- Changes look good, plenty of tests
- Changeset ✅
- Did not test manually
#3384 - Add Credentials section to README explaining env: variable requirement - Update --username/--password CLI option descriptions in deploy and undeploy tables - Add cliCmdWithBasicAuth test case to CLI integration tests
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validateCredentials()guard insrc/base/config.ts— throws ifusernameorpasswordis present but does not start withenv:, ensuring credentials are always resolved from environment variablesvalidateConfig()beforereplaceEnvVariablesruns, covering both the CLI and UI5 task entry pointsNonNullable<AbapDeployConfig['credentials']>to eliminate redundant null guard inside the functionCloses #1156
Test plan
pnpm buildpassespnpm --filter @sap-ux/deploy-tooling lintpasses (0 errors)pnpm --filter @sap-ux/deploy-tooling testpasses (126/126)env:passes, absent credentials passes, only env-prefixed username passesdeploy-tooling-prevent-cleartext-credentials.md(patch)