@@ -179,7 +179,7 @@ func (c *external) Observe(ctx context.Context, mg resource.Managed) (managed.Ex
179179 var credentialsUpToDate bool
180180 desiredCredentials , err := extractCredentialSpec (ctx , c .kube , cr .Spec .ForProvider )
181181 if err != nil {
182- return managed.ExternalObservation {}, checkDelition (cr , errors .Wrap (err , errSecret ))
182+ return managed.ExternalObservation {}, checkDeletion (cr , errors .Wrap (err , errSecret ))
183183 }
184184 // If parameter drift detection is enable, get actual credentials from the service instance
185185 if cr .Spec .EnableParameterDriftDetection {
@@ -209,9 +209,13 @@ func (c *external) Observe(ctx context.Context, mg resource.Managed) (managed.Ex
209209 }
210210}
211211
212- func checkDelition (cr * v1alpha1.ServiceInstance , err error ) error {
212+ // checkDeletion returns nil if the ServiceInstance is already marked for deletion.
213+ // Why: Avoid noisy retries while Kubernetes finalizers finish cleanup.
214+ // Params:
215+ // cr - ServiceInstance under reconciliation
216+ // err - original error (returned only when not deleting)
217+ func checkDeletion (cr * v1alpha1.ServiceInstance , err error ) error {
213218 if cr .GetDeletionTimestamp () != nil {
214- // we are in deletion, do not return error to avoid retry
215219 return nil
216220 }
217221 return err
0 commit comments