fix: service instance deletion

Author: Mykhailo Pechkurov

internal/controller/serviceinstance/controller.go

@@ -179,7 +179,7 @@ func (c *external) Observe(ctx context.Context, mg resource.Managed) (managed.Ex
 		var credentialsUpToDate bool
 		desiredCredentials, err := extractCredentialSpec(ctx, c.kube, cr.Spec.ForProvider)
 		if err != nil {
-			return managed.ExternalObservation{}, errors.Wrap(err, errSecret)
+			return managed.ExternalObservation{}, checkDelition(cr, errors.Wrap(err, errSecret))
 		}
 		// If parameter drift detection is enable, get actual credentials from the service instance
 		if cr.Spec.EnableParameterDriftDetection {
@@ -209,6 +209,14 @@ func (c *external) Observe(ctx context.Context, mg resource.Managed) (managed.Ex
 	}
 }
 
+func checkDelition(cr *v1alpha1.ServiceInstance, err error) error {
+	if cr.GetDeletionTimestamp() != nil {
+		// we are in deletion, do not return error to avoid retry
+		return nil
+	}
+	return err
+}
+
 // Create attempts to create the external resource.
 func (c *external) Create(ctx context.Context, mg resource.Managed) (managed.ExternalCreation, error) {
 	cr, ok := mg.(*v1alpha1.ServiceInstance)