fix: Adjust keyboard navigation of external inputs#9820
Merged
Conversation
maribethb
approved these changes
May 6, 2026
Contributor
maribethb
left a comment
maribethb
left a comment
There was a problem hiding this comment.
suggestion for the tsdoc: s/visual/logical when you describe "rows" since they aren't really visual anymore but more a logical grouping of things
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
This PR adjusts the behavior of keyboard navigation on blocks, particularly those with external inputs. Previously, every empty external input or block connected to an external input was treated as being on its own row, so that pressing the up/down arrows would move focus to the next "row". For example, in this screenshot, pressing up would focus the empty "if true" input, then the "if false" input on the most-deeply-nested ternary block, and so forth.
Now, rows are demarcated solely by (a) next/previous connections (b) separate block stacks, and (c) statement inputs. All nested blocks/inputs/fields inside a block that has a next/previous connection, is a root block, or is part of a clause of a block that has statement inputs are treated as being on its same row. Thus, up arrow in the screenshot above would take you to the previous block stack. Nested inputs/blocks may be visited via the left and right arrows.