fix: Fix bug that could cause unintend block movements#9818
Open
fix: Fix bug that could cause unintend block movements#9818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9708
Proposed Changes
This PR fixes a bug that caused unintended block movements in Chrome. When blocks are focused, they scroll themselves into view, so that keyboard navigation doesn't focus an offscreen block. Now, blocks only do so if there was already a focused node - this still works in the keyboard nav case (if the block gains focus via a click, it must have been on screen, and if it gains focus via the keyboard, something else e.g. the workspace or another block had to have focus first), but avoids a situation where blocks would try to refocus themselves or focus during intermediate transition states between the drag layer and main workspace layer where focus could be lost as elements were added and removed from the DOM.