fix: Add punctuation to live region announcements#9817
Open
mikeharv wants to merge 2 commits intoRaspberryPiFoundation:v13from
Open
fix: Add punctuation to live region announcements#9817mikeharv wants to merge 2 commits intoRaspberryPiFoundation:v13from
mikeharv wants to merge 2 commits intoRaspberryPiFoundation:v13from
Conversation
1 task
mikeharv
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9801
Proposed Changes
This adds punctation and capital letters where needed to Toast text and ARIA live region announcement messages. This makes things more readable, especially when multiple messages are coalesced.
Reason for Changes
The aria-live region now coalesces messages together when required, however, the messages lack punctuation, and when they are concatenated, the screen outputs one long sentence with varying levels of sense.
Example: "moving on workspace" is appended to the move mode hint but no full stop separates these two distinct sentences so they are no longer distinct.
(Without changes...)
Test Coverage
Tests that expect exact string literals were also updated accordingly.