Source ranges#339
Merged
jkrumbiegel merged 14 commits intomainfrom Sep 26, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
==========================================
+ Coverage 79.43% 80.10% +0.67%
==========================================
Files 39 39
Lines 2071 2106 +35
==========================================
+ Hits 1645 1687 +42
+ Misses 426 419 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6 tasks
MichaelHatherly
requested changes
Sep 26, 2025
Collaborator
MichaelHatherly
left a comment
There was a problem hiding this comment.
Only one changed requested to avoid accessing a field and rather using first() instead.
Collaborator
Author
|
I wasn't sure at first if there could be empty ranges (for which first would error) but I think that can't happen even in the weird cases that quarto inserts |
MichaelHatherly
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the QNR side of fixing #310, the corresponding PR in quarto-cli is quarto-dev/quarto-cli#13401. This PR will have to be merged and tagged first before the quarto PR can pass final CI and be merged as well. The change is backwards compatible in that if no source ranges are supplied, the original file's line numbers are used like before.
The effect of this is that evaluated Julia cells get the correct file paths and line numbers so that code in includes can be correctly traced back. For example something like this (plus includes that also print file and line)
gives something like this