ci: story baselines move to a companion repo — snapshot-per-commit, merge-is-acceptance - #425
Draft
Yona-Appletree wants to merge 3 commits into
Draft
ci: story baselines move to a companion repo — snapshot-per-commit, merge-is-acceptance#425Yona-Appletree wants to merge 3 commits into
Yona-Appletree wants to merge 3 commits into
Conversation
validate-stories no longer reads or writes baselines in this repo. Baselines live in PhotomancerArt/lightplayer-stories as one snapshot commit per captured main commit (sha-<sha> refs, parented on the compared-against snapshot); PR runs compare against the nearest captured ancestor, push a pr-<n> snapshot via the lightplayer-infra app token, and post a sticky comment with thumbnails and a compare link. Visual changes PASS — merging is acceptance. Auto-commit, bot heads, and PNG add/add conflicts are gone structurally. New: story-baseline-lookup.mjs (ancestor walk + shallow fetch), story-snapshot.mjs (manifest-applied snapshot builder; tolerated evidence rides in tolerated/). Rewritten: story-drift-comment.mjs. Committed baselines stay in-tree until the G1 gate passes (cutover is P3). Plan: lp2025/2026-08-14-1132-story-baselines-external Co-Authored-By: Claude Fable 5 <[email protected]>
Deliberate label tweak in the inline-button in-a-row story so the G1 gate has a real modified-story comment + compare view to judge. Revert this commit once the gate passes. Plan: lp2025/2026-08-14-1132-story-baselines-external Co-Authored-By: Claude Fable 5 <[email protected]>
…HEAD^1 The depth-1 checkout grafts HEAD as parentless, so 'git rev-parse HEAD^1' fails with 'unknown revision' even after the depth-60 main fetch. Read the first-parent sha from the raw commit header instead, which shallow grafts do not touch. Plan: 2026-08-14-1132-story-baselines-external Co-Authored-By: Claude Fable 5 <[email protected]>
Contributor
Story visual changesThis PR changes rendered stories: 28 changed. Review all changes in the stories repo (swipe / onion-skin on every PNG). Baseline: main
20 more file(s)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan: lp2025/2026-08-14-1132-story-baselines-external
Path: ~/.photomancer/planning/lp2025/2026-08-14-1132-story-baselines-external/plan.md
P2 of the story-baselines companion-repo plan
Moves story-baseline storage OUT of this repo:
validate-storiesnowcompares against a snapshot fetched from
lightplayer-stories
(nearest captured main ancestor), pushes the fresh capture there as a
pr-<n>snapshot (app-token auth), and posts a sticky comment withbefore/after thumbnails plus a compare link. Visual changes PASS CI —
merging is acceptance. Nothing in CI writes to this repo anymore
(
contents: read).Committed baselines under
story-images/are deliberately untouched — theyare deleted in P3 only after the G1 gate passes. The last commit is a
deliberate visible story tweak (G1 probe) and gets reverted before merge.
Status: P1 done (repo seeded from main
bcd1ac433, refsha-bcd1ac…+latest). This PR is the live test rig for gate G1.Resume notes: read
plan.md+p2-pipeline-rewrite.mdin the planning dir;P1 deviation (deploy keys disabled →
lightplayer-infraapp token) is inp1-companion-repo-seed.md→ Implementation Result.🤖 Generated with Claude Code