Remove "m_floor" step from breach ring aura effect calculation.#9834
Open
JLMSC wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Open
Remove "m_floor" step from breach ring aura effect calculation.#9834JLMSC wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
JLMSC wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
… converted values (<1) were being incorreclty rounded down to 0 on a per-node basis. Removing the floor allows the floating values to be preserved and correctly added together in the final sum, fixing an issue where small percentage increases were being lost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9721
Description of the problem being solved:
Small converted values (< 1) were being incorrectly discarded during the per-mod conversion step for Breach ring Aura Effect scaling (e.g.
"Auras from ... at (10-15)% of their value, up to a maximum of 150%").The issue occurred because each individual damage source was:
mod.value * multiplier)m_floorThis caused loss of fractional contributions from small sources.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
These PoB are the same provided in the issue.
1- https://pobb.in/zBPqbSTWQ5do - After the changes it is noticeable the damage increase lost because of the round step in the aura effect calculation process.
(From Hit DPS: 1,341,983,007.8 to Hit DPS: 1,431,909,704.3, in both cases the item "The Will of Xoph" were equipped)
2- https://pobb.in/1evKsFjeHOuN - Here it is possible to see the increases from smaller values.
(From Aura Effect Mod: x1.15 to Aura Effect Mod: x1.45, no changes to the build were made)
Before screenshot:
PoB 1, Scenario were the round step is ENABLED
PoB 2, Scenario were the round step is ENABLED
After screenshot:
PoB 1, Scenario were the round step is REMOVED
PoB 2, Scenario were the round step is REMOVED
