Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #856 +/- ##
==========================================
- Coverage 27.19% 27.19% -0.01%
==========================================
Files 673 673
Lines 44165 44165
==========================================
- Hits 12012 12011 -1
- Misses 32153 32154 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hit a upstream issue tuist/tuist#10616 |
🤖 Augment PR SummarySummary: This PR switches XCFramework packaging to emit a single Changes:
Technical Notes: Package manifest gains 🤖 Was this summary useful? React with 👍 or 👎 |
| local swiftmodule | ||
| swiftmodule="$(find_swiftmodule "$build_products_path" "$archive_path" "$module_name")" | ||
| if [ -z "$swiftmodule" ]; then | ||
| echo "Warning: No swiftmodule found for $module_name." |
There was a problem hiding this comment.
copy_swiftmodule only warns when a module’s .swiftmodule can’t be found, but DEP_MODULES are described as being referenced by public .swiftinterfaces; proceeding could silently produce a broken XCFramework that fails for consumers. Consider making missing swiftmodules a hard failure (at least for DEP_MODULES) so CI/release artifacts can’t be published incomplete.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
A replacement of #807
Summary
OpenSwiftUI.xcframework--debugis passedCOpenSwiftUIinto the final dynamic OpenSwiftUI frameworkVerification
mise installswift package dump-packagetuist generate --no-openbash -n Scripts/build_xcframework.shgit diff --check/tmp/openswiftui-xcframework-objc-full/OpenSwiftUI.xcframework*.abi.json, and is ~46MNSMenu(OpenSwiftUI_SPI)category methods are present in the final OpenSwiftUI Mach-Oswift run DemoKitstarts without the NSMenu unrecognized selector crashxcodebuild -scheme DemoKit -destination "platform=macOS" -derivedDataPath /tmp/DemoKit-objc-full-dd buildNotes
The current single-binary package consumption still needs module search path flags for nested Swift modules copied into
OpenSwiftUI.framework/Modules. The paired OpenSwiftUI-spm PR updates the binary package template to publish only the OpenSwiftUI binary target.