fix(src): map to return object .prototype undefined#147
Merged
DerekNonGeneric merged 3 commits intoOpenINF:mainfrom Oct 18, 2022
Merged
fix(src): map to return object .prototype undefined#147DerekNonGeneric merged 3 commits intoOpenINF:mainfrom
DerekNonGeneric merged 3 commits intoOpenINF:mainfrom
Conversation
Signed-off-by: Derek Lewis <[email protected]>
Signed-off-by: Derek Lewis <[email protected]>
DerekNonGeneric
added a commit
that referenced
this pull request
Nov 3, 2022
Co-authored-by: Restyled Commits <[email protected]> Signed-off-by: Derek Lewis <[email protected]> Signed-off-by: Restyled Commits <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently have a test for this to ensure that the object returned from
maphas a prototype of typeundefined; i would like to know if it would also be acceptable (or perhaps preferable) for the returned object to have a prototype of type null…Refs: #138 (comment)