Fix: add initializer_range default to GO1ModelConfig#156
Open
wadeKeith wants to merge 1 commit intoOpenDriveLab:mainfrom
Open
Fix: add initializer_range default to GO1ModelConfig#156wadeKeith wants to merge 1 commit intoOpenDriveLab:mainfrom
wadeKeith wants to merge 1 commit intoOpenDriveLab:mainfrom
Conversation
Fixes AttributeError when loading GO-1 pretrained checkpoint from HuggingFace. The _init_weights method in modeling_action_expert.py accesses self.config.initializer_range, but GO1ModelConfig did not have this attribute set. Issue: OpenDriveLab#126
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #126
Problem
When loading GO-1 pretrained checkpoint from HuggingFace (agibot-world/GO-1), the model fails during initialization with:
This occurs in
modeling_action_expert.pyline 513, where_init_weightsaccessesself.config.initializer_range, butGO1ModelConfigdid not have this attribute.Solution
Add
initializer_range = 0.02as a default attribute inGO1ModelConfig.__init__.Changes
go1/internvl/model/go1/configuration_go1.py: Addedself.initializer_range = 0.02