fix: ci by Z-G-H1 · Pull Request #3204 · OpenAtomFoundation/pikiwidb

Z-G-H1 · 2025-12-07T13:18:28Z

Summary by CodeRabbit

Chores
- Optimized CI/CD build cleanup to restrict deletions to workspace and build-related artifacts, reducing risk of removing unrelated system files.
- Removed noisy diagnostic output while keeping a final disk-usage check, improving log clarity and build reliability.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Added a step to debug disk usage after the build process, providing insights into disk space and large files.

coderabbitai · 2025-12-07T13:18:39Z

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Replaces the broad, system-wide "Extreme Disk Cleanup" in the CentOS CI job with workspace-scoped deletions under /__w/pikiwidb/pikiwidb, removing specific build-related directories and artifacts and eliminating extra diagnostic reporting lines; other workflow steps remain unchanged.

Changes

Cohort / File(s)	Summary
CI workflow cleanup (CentOS) `/.github/workflows/pika.yml`	Removed broad system-wide deletions and extra diagnostics; added targeted cleanup under `/__w/pikiwidb/pikiwidb` that deletes build-related dirs (`buildtrees`, `deps`), large library artifacts (`librocksdb.a`, `libprotoc.a`, `libprotobuf.a`), intermediate files (`.o`, `.a`, `.la`, `.so`, `*_test`), and the workspace `.git`; retained final `df -h`.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Verify the workspace path (/__w/pikiwidb/pikiwidb) is correct for all runners.
Ensure the targeted deletion patterns don't unintentionally remove needed artifacts.
Confirm error redirection to /dev/null and removed diagnostics are acceptable.

Possibly related PRs

fix:fix CI #2924 — modifies the same workflow and refactors build/cleanup steps.
fix: add centos CI in github action #2942 — also edits the CentOS job's cleanup step; compares differing cleanup approaches.
fix:Unstable ci #3201 — earlier PR that introduced aggressive global cleanup which this change narrows.

Suggested reviewers

Mixficsol

Poem

🐰
I nibbled crumbs in buildtree rows, so small,
Pruned only where the workspace needed all.
No sweeping paws across the system wide,
Just tidy hops where artifacts hide. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'fix: ci' is too vague and generic, lacking specificity about what CI aspect is being fixed.	Use a more descriptive title that specifies the nature of the CI fix, such as 'fix: optimize disk cleanup in CentOS CI workflow' or 'fix: refine artifact cleanup strategy in CI pipeline'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2cae817 and 7bc6717.

📒 Files selected for processing (1)

.github/workflows/pika.yml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

.github/workflows/pika.yml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: build_on_centos
GitHub Check: build_on_ubuntu
GitHub Check: build_on_macos
GitHub Check: Analyze (go)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR optimizes the CI workflow disk cleanup strategy for the CentOS build job. The changes replace an aggressive, system-wide cleanup approach with targeted cleanup of specific project-related directories and build artifacts.

Key changes:

Simplified the "Extreme Disk Cleanup" step with more focused cleanup commands
Removed aggressive system-wide cleanup operations (e.g., /usr/local/share/*, /usr/share/doc/*)
Targeted cleanup of specific build artifacts and large static libraries

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-07T13:20:33Z

+          rm -rf /__w/pikiwidb/pikiwidb/buildtrees 2>/dev/null || true
+          rm -rf /__w/pikiwidb/pikiwidb/deps 2>/dev/null || true 
+          find /__w/pikiwidb/pikiwidb -type f \( -name "librocksdb.a" -o -name "libprotoc.a" -o -name "libprotobuf.a" \) -delete 2>/dev/null || true
+          find /__w/pikiwidb/pikiwidb -type f \( -name "*.o" -o -name "*.a" -o -name "*.la" -o -name "*.so" -o -name "*_test" \) ! -path "*/build/pika" -delete 2>/dev/null || true
+          rm -rf /__w/pikiwidb/pikiwidb/.git 2>/dev/null || true


The hardcoded path /__w/pikiwidb/pikiwidb should be replaced with ${{ github.workspace }} for portability and to avoid issues if the repository or GitHub Actions runner configuration changes. This pattern is used consistently throughout the workflow file (see lines 65, 68, 74, 87, 96, etc.).

Copilot · 2025-12-07T13:20:34Z

-          echo "Largest directories:"
-          du -h --max-depth=2 / 2>/dev/null | sort -hr | head -20
+          rm -rf /__w/pikiwidb/pikiwidb/buildtrees 2>/dev/null || true
+          rm -rf /__w/pikiwidb/pikiwidb/deps 2>/dev/null || true 


Trailing whitespace detected after || true. Consider removing it for consistency with YAML formatting standards.

Suggested change

rm -rf /__w/pikiwidb/pikiwidb/deps 2>/dev/null || true

rm -rf /__w/pikiwidb/pikiwidb/deps 2>/dev/null || true

Copilot · 2025-12-07T13:20:34Z

+          find /__w/pikiwidb/pikiwidb -type f \( -name "librocksdb.a" -o -name "libprotoc.a" -o -name "libprotobuf.a" \) -delete 2>/dev/null || true
+          find /__w/pikiwidb/pikiwidb -type f \( -name "*.o" -o -name "*.a" -o -name "*.la" -o -name "*.so" -o -name "*_test" \) ! -path "*/build/pika" -delete 2>/dev/null || true
+          rm -rf /__w/pikiwidb/pikiwidb/.git 2>/dev/null || true
+          df -h  


Trailing whitespace detected after df -h. Consider removing it for consistency with YAML formatting standards.

Suggested change

df -h

df -h

Z-G-H1 added 2 commits December 7, 2025 21:10

Add disk usage debugging step in workflow

96b0e6f

Added a step to debug disk usage after the build process, providing insights into disk space and large files.

fix ci

2cae817

Copilot AI review requested due to automatic review settings December 7, 2025 13:18

github-actions Bot added the ☢️ Bug Something isn't working label Dec 7, 2025

Copilot started reviewing on behalf of Z-G-H1 December 7, 2025 13:18 View session

Copilot AI reviewed Dec 7, 2025

View reviewed changes

Fix formatting

7bc6717

chejinge merged commit a99e06b into OpenAtomFoundation:unstable Dec 8, 2025
13 checks passed

This was referenced Dec 9, 2025

feat: Pika Quality #3194

Closed

fix: write-buffer-size overflow #3193

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: ci#3204

fix: ci#3204
chejinge merged 3 commits intoOpenAtomFoundation:unstablefrom
Z-G-H1:unstable

Z-G-H1 commented Dec 7, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Dec 7, 2025 •

edited

Loading

Other AI code review bot(s) detected

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 7, 2025

Uh oh!

Copilot AI Dec 7, 2025

Uh oh!

Copilot AI Dec 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	rm -rf /__w/pikiwidb/pikiwidb/deps 2>/dev/null \|\| true
	rm -rf /__w/pikiwidb/pikiwidb/deps 2>/dev/null \|\| true

Conversation

Z-G-H1 commented Dec 7, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Other AI code review bot(s) detected

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Z-G-H1 commented Dec 7, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Dec 7, 2025 •

edited

Loading