feat:add 3.5.6 changelog#3156
Conversation
WalkthroughAdds V3.5.6 entries to English and Chinese changelogs, detailing improvements (timing stats, logging, thread-pool changes, connection handling) and numerous bug fixes across caching, replication, and command processing. Also includes minor formatting edits to existing sections. No code or API changes in this diff. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
✏️ Feature
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (5)
CHANGELOG_CN.MD (2)
11-11: Polish Chinese phrasing for clarityRemove redundant “close” and improve fluency.
-- 当 client 关闭 close 链接之后，服务端在处理请求时跳过执行这条连接上收到的请求，避免出现请求堵塞问题[#3111](https://github.com/OpenAtomFoundation/pikiwidb/pull/3111)@[wangshao1](https://github.com/wangshao1) +- 当客户端关闭连接后，服务端在处理请求时跳过该连接上已收到的请求，避免出现请求阻塞问题[#3111](https://github.com/OpenAtomFoundation/pikiwidb/pull/3111)@[wangshao1](https://github.com/wangshao1)
37-37: Unify terminology/case: RedisCache, pipeline/AUTH, command namesKeep product/feature names and command casing consistent.
-- 修复 rediscache 最大存储范围不准确的问题[#3064](https://github.com/OpenAtomFoundation/pikiwidb/pull/3064)@[Mixficsol](https://github.com/Mixficsol) +- 修复 RedisCache 最大存储范围不准确的问题[#3064](https://github.com/OpenAtomFoundation/pikiwidb/pull/3064)@[Mixficsol](https://github.com/Mixficsol) -- 在 pipeline模式下将 auth 命令和后续在 Pipeline 中的命令划分到命令线程池[#3098](https://github.com/OpenAtomFoundation/pikiwidb/pull/3098)@[Mixficsol](https://github.com/Mixficsol) +- 在 Pipeline 模式下，将 AUTH 命令及其后续命令分配到命令线程池[#3098](https://github.com/OpenAtomFoundation/pikiwidb/pull/3098)@[Mixficsol](https://github.com/Mixficsol) -- 修复 ZRemrangebylex和zremrangebyscore等命令传参错误的问题[#3098](https://github.com/OpenAtomFoundation/pikiwidb/pull/3098)@[chenbt-hz](https://github.com/chenbt-hz) +- 修复 zremrangebylex、zremrangebyscore 等命令传参错误的问题[#3098](https://github.com/OpenAtomFoundation/pikiwidb/pull/3098)@[chenbt-hz](https://github.com/chenbt-hz) -- 修复 rediscache部分读接口没有加锁，当rediscache在做 rehash 时会做数据挪动，可能导致数据竞争的问题[#3088](https://github.com/OpenAtomFoundation/pikiwidb/pull/3088)@[wangshao1](https://github.com/wangshao1) +- 修复 RedisCache 部分读接口未加锁的问题；当 RedisCache 进行 rehash 时会发生数据挪动，可能导致数据竞争[#3088](https://github.com/OpenAtomFoundation/pikiwidb/pull/3088)@[wangshao1](https://github.com/wangshao1)Also applies to: 41-41, 43-43, 45-45
CHANGELOG.MD (3)
14-14: Align section heading style (“Bugfix” vs “Bugfixes”)Elsewhere the doc frequently uses “Bugfix”. Pick one and stick to it; suggest singular here.
-## Bugfixes +## Bugfix
42-42: Clarify pipeline item and casingMinor grammar/case tweaks.
- In pipeline mode, moved auth commands and subsequent commands in the Pipeline to command thread pool [#3098](https://github.com/OpenAtomFoundation/pikiwidb/pull/3098)@[Mixficsol](https://github.com/Mixficsol) + In pipeline mode, moved the AUTH command and subsequent pipeline commands to the command thread pool [#3098](https://github.com/OpenAtomFoundation/pikiwidb/pull/3098)@[Mixficsol](https://github.com/Mixficsol)
11-11: Tighten wording for disconnection behaviorMore natural phrasing.
- After a client closes the connection, the server skips requests received on this connection during processing to avoid request blocking [#3111](https://github.com/OpenAtomFoundation/pikiwidb/pull/3111)@[wangshao1](https://github.com/wangshao1) + After a client disconnects, the server skips processing any requests received on that connection to avoid request blocking [#3111](https://github.com/OpenAtomFoundation/pikiwidb/pull/3111)@[wangshao1](https://github.com/wangshao1)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.MD(2 hunks)CHANGELOG_CN.MD(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: build_on_centos
- GitHub Check: build_on_macos
- GitHub Check: build_on_ubuntu
- GitHub Check: Analyze (go)
🔇 Additional comments (2)
CHANGELOG_CN.MD (1)
1-69: V3.5.6 CN entry reads well overallContent is comprehensive and consistent with recent changes.
CHANGELOG.MD (1)
1-69: V3.5.6 EN entry is clear and mirrors CN wellGood coverage and linkage to PRs.
| - 修复 requirepass 是非空的但可通过任意密码连接的问题[#3113](https://github.com/OpenAtomFoundation/pikiwidb/pull/3107)@[YuCai18](https://github.com/YuCai18) | ||
|
|
There was a problem hiding this comment.
Fix mismatched PR link for requirepass bug
Displayed issue number is #3113 but the URL points to /pull/3107. Update the URL to the correct PR to avoid a broken or misleading reference.
Apply this diff:
-- 修复 requirepass 是非空的但可通过任意密码连接的问题[#3113](https://github.com/OpenAtomFoundation/pikiwidb/pull/3107)@[YuCai18](https://github.com/YuCai18)
+- 修复 requirepass 非空时可用任意密码连接的问题[#3113](https://github.com/OpenAtomFoundation/pikiwidb/pull/3113)@[YuCai18](https://github.com/YuCai18)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - 修复 requirepass 是非空的但可通过任意密码连接的问题[#3113](https://github.com/OpenAtomFoundation/pikiwidb/pull/3107)@[YuCai18](https://github.com/YuCai18) | |
| - 修复 requirepass 非空时可用任意密码连接的问题[#3113](https://github.com/OpenAtomFoundation/pikiwidb/pull/3113)@[YuCai18](https://github.com/YuCai18) |
🤖 Prompt for AI Agents
In CHANGELOG_CN.MD around lines 59-60, the PR link text references issue #3113
but its URL incorrectly points to /pull/3107; update the URL to /pull/3113 so
the markdown link becomes consistent (i.e., change the href from
https://github.com/OpenAtomFoundation/pikiwidb/pull/3107 to
https://github.com/OpenAtomFoundation/pikiwidb/pull/3113) while keeping the
displayed text and author mention unchanged.
|
|
||
| - Fixed error in codis-proxy logging [#3107](https://github.com/OpenAtomFoundation/pikiwidb/pull/3107)@[wangshao1](https://github.com/wangshao1) | ||
|
|
||
| - Fixed issue where requirepass was non-empty but connections could still be made with any password [#3113](https://github.com/OpenAtomFoundation/pikiwidb/pull/3107)@[YuCai18](https://github.com/YuCai18) |
There was a problem hiding this comment.
Fix mismatched PR link for requirepass bug
Text says #3113 but URL points to /pull/3107. Point to the correct PR.
-- Fixed issue where requirepass was non-empty but connections could still be made with any password [#3113](https://github.com/OpenAtomFoundation/pikiwidb/pull/3107)@[YuCai18](https://github.com/YuCai18)
+- Fixed issue where requirepass was non-empty but connections could still be made with any password [#3113](https://github.com/OpenAtomFoundation/pikiwidb/pull/3113)@[YuCai18](https://github.com/YuCai18)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - Fixed issue where requirepass was non-empty but connections could still be made with any password [#3113](https://github.com/OpenAtomFoundation/pikiwidb/pull/3107)@[YuCai18](https://github.com/YuCai18) | |
| - Fixed issue where requirepass was non-empty but connections could still be made with any password [#3113](https://github.com/OpenAtomFoundation/pikiwidb/pull/3113)@[YuCai18](https://github.com/YuCai18) |
🤖 Prompt for AI Agents
In CHANGELOG.MD around line 60, the entry references PR #3113 but the link
targets /pull/3107; update the URL to match the referenced PR by changing the
link to /pull/3113 (i.e. replace
"https://github.com/OpenAtomFoundation/pikiwidb/pull/3107" with
"https://github.com/OpenAtomFoundation/pikiwidb/pull/3113") so the displayed PR
number and URL are consistent.
Co-authored-by: chejinge <[email protected]>
4 participants
Summary by CodeRabbit
New Features
Bug Fixes
Chores