feat:Batch refactoring of strongly consistent code#3147
Closed
YuCai18 wants to merge 1 commit intoOpenAtomFoundation:feature/consistency_3.5from
Closed
feat:Batch refactoring of strongly consistent code#3147YuCai18 wants to merge 1 commit intoOpenAtomFoundation:feature/consistency_3.5from
YuCai18 wants to merge 1 commit intoOpenAtomFoundation:feature/consistency_3.5from
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
YuCai18
changed the title
wangshao1
reviewed
Aug 14, 2025
| std::promise<void> promise; | ||
| task->futures.push_back(promise.get_future()); | ||
|
|
||
| g_pika_server->ScheduleClientPool(&PikaClientConn::ParallelExecRedisCmd, new std::tuple(shared_from_this(), argvs[i], task, i, std::move(promise), cache_miss_in_rtc), false, false); |
Collaborator
There was a problem hiding this comment.
你目前压测的方式，这里的argvs都是一个，只有客户端使用pipeline方式的时候才会大于1.
另外，如果是pipeline的方式压测，你这里的逻辑是把这些命令执行又拆分到同一个线程池，线程池都占满的时候，会不会导致hang住？
| bool window_elapsed = (now_us - leader_election_token) >= timeout_us; | ||
| bool enough_accumulated = ws->accepted.load(std::memory_order_relaxed) >= min_batch_wait; | ||
|
|
||
| if (!window_elapsed && !enough_accumulated) { |
Collaborator
There was a problem hiding this comment.
这里是说没攒够指定时间和个数，就直接return？那不就直接写rocksdb了吗？
Collaborator
Author
There was a problem hiding this comment.
你说的对，这里需要改成“或”，满足一个条件就发送，不能提前返回。
YuCai18
force-pushed
the
feature/consistency_3.5
branch
from
1d9bac4 to
797ffa6
Compare
Mixficsol
reviewed
Aug 25, 2025
| g_pika_server->CheckLeaderProtectedMode(); | ||
|
|
||
| // TODO(whoiami) timeout | ||
| s = g_pika_server->TriggerSendBinlogSync(); |
Collaborator
There was a problem hiding this comment.
需要理一下这里为什么 TriggerSendBinlogSync 位置需要换
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
单线程压测结果：
多线程压测结果：
