Skip to content

fix:Type Command Expired Key Consistency #3132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mixficsol merged 2 commits into from
Jul 22, 2025
+8 −1
Merged

fix:Type Command Expired Key Consistency #3132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cdad27
Fix Type Command Expired Key Consistency
YuCai18 Jul 20, 2025
0e25a5b
Change to English comments
YuCai18 Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/storage/src/redis_strings.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1671,7 +1671,14 @@ rocksdb::Status Redis::GetType(const storage::Slice& key, enum DataType& type) {
BaseMetaKey base_meta_key(key);
rocksdb::Status s = db_->Get(default_read_options_, handles_[kMetaCF], base_meta_key.Encode(), &meta_value);
if (s.ok()) {
type = static_cast<enum DataType>(static_cast<uint8_t>(meta_value[0]));
// Check if key has expired
if (ExpectedStale(meta_value)) {
type = DataType::kNones; // If key has expired, return "none" type
} else {
type = static_cast<enum DataType>(static_cast<uint8_t>(meta_value[0]));
}
} else {
type = DataType::kNones; // If key doesn't exist, return "none" type
}
return Status::OK();
}
Expand Down
Loading