fix:SETEX replication does not work(pika-unstable)

[YuCai18]

修复了pika unstable版本中setex在主从上不同步的bug #3117

修改的代码部分

1.命令名称错误：

修改了SetexCmd::ToRedisProtocol()和PsetexCmd::ToRedisProtocol()方法。原代码中，SetexCmd::ToRedisProtocol()方法生成的是pksetexat命令，而不是标准的setex命令。同样，PsetexCmd::ToRedisProtocol()也生成了错误的命令名称。在主从复制过程中，主节点会将命令转换为二进制日志(binlog)发送给从节点，所以从节点无法正确识别和执行这些非标准命令。

2.过期时间计算错误：

原代码中计算过期时间使用了time(nullptr) + ttl_sec_（对于SETEX）和pstd::NowMillis() + ttl_millsec（对于PSETEX）。这意味着主节点计算的是"当前时间+过期秒数"作为绝对过期时间点。当从节点接收到这个命令时，它会直接使用这个绝对时间，而不是重新计算。由于主从之间可能存在时间差或者命令传输延迟，这会导致从节点上的实际过期时间与主节点不一致。

修改后的运行截图

Summary by CodeRabbit

• Bug Fixes
  • Updated command formatting for improved compatibility with standard Redis clients by using standard command names and TTL handling in protocol output.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes update the ToRedisProtocol() methods for the SetexCmd and PsetexCmd classes, modifying the command names in the Redis protocol output to standard Redis commands and adjusting the TTL argument to use the direct TTL value instead of a calculated timestamp.

Changes

File(s)	Change Summary
src/pika_kv.cc	Updated ToRedisProtocol() in SetexCmd and PsetexCmd to use standard command names and direct TTL values in Redis protocol output.

Suggested labels

4.0.0, 3.5.5

Suggested reviewers

• chejinge
• AlexStocks

Poem

A tweak in the code, a hop in my stride,
Redis commands now match, no need to hide!
TTLs are clear, no timestamp to add—
The protocol’s happy, the rabbits are glad!
With every small fix, the garden grows neat,
CodeRabbit’s work is always a treat! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8b077fc and 332d3d7.

📒 Files selected for processing (1)

• src/pika_kv.cc (2 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.