fix: requirepass allows connection with any non-empty password (unstable)#3114
Merged
Mixficsol merged 1 commit intoOpenAtomFoundation:unstablefrom Jun 20, 2025
Merged
Conversation
byseea11
pushed a commit
to byseea11/pikiwidb
that referenced
this pull request
Sep 27, 2025
…ble) (OpenAtomFoundation#3114) Co-authored-by: caiyu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复bug #3085 ：解决requirepass是非空的但可通过任意密码连接(unstable版本)
requirepass 为非空时填写任意字符串即可连接的原因
因为src/acl.cc文件中的Acl::InitLimitUser()函数的没有设置else分支，若 userpass 为空且requirepass不为空，limit 用户就会被设置为 nopass（免密），任何密码都能通过；若userpass 和 requirepass 都为空，所有用户都是管理员；若userpass 不为空且requirepass为空就会报(error) ERR Client sent AUTH, but no password is set的错误。
修改后的运行截图