Skip to content

fix: ensure ZADD keeps the last score for duplicate members in a single command to align with Redis behavior#3108

Merged
wangshao1 merged 1 commit intoOpenAtomFoundation:3.5from
YuCai18:hotfix3.5/fix_zsetzadd
Jun 13, 2025
Merged

fix: ensure ZADD keeps the last score for duplicate members in a single command to align with Redis behavior#3108
wangshao1 merged 1 commit intoOpenAtomFoundation:3.5from
YuCai18:hotfix3.5/fix_zsetzadd

Conversation

@YuCai18
Copy link
Copy Markdown
Collaborator

@YuCai18 YuCai18 commented Jun 13, 2025

修复bug #3078 : 修正 pika 中 zadd 命令在单行多次添加同一 member 时与 Redis 行为不一致的问题

问题重现

image-20250612165250717

执行zadd key score1 member1 score2 member1返回score1的原因

image

在 src/storage/src/redis_zsets.cc 文件中,RedisZSets::ZAdd 函数存在问题:源代码在这里是从前往后读取score_members数组的,导致与src/pika_cache.cc中的PikaCache::ZAddIfKeyExist函数的从后往前读取score_members数组冲突,程序未能读取到正确的缓存数据。

修改文件部分

  • 在src/storage/src/redis_zsets.cc 文件中修改了对score_members数组的从后往前读取方式,与PikaCache::ZAddIfKeyExist中的unordered_set+list的方式一致。
  • 在zset_test.go文件中追加了测试用例并通过了测试。

image-20250613112526622

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 13, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions Bot added ☢️ Bug Something isn't working ✏️ Feature New feature or request labels Jun 13, 2025
@YuCai18 YuCai18 changed the title fix: ensure ZADD keeps the last score for duplicate members in a single command to align with Redis behavior #3078 fix: ensure ZADD keeps the last score for duplicate members in a single command to align with Redis behavior Jun 13, 2025
@YuCai18 YuCai18 force-pushed the hotfix3.5/fix_zsetzadd branch from f7d5575 to b8ad2a4 Compare June 13, 2025 06:27
@wangshao1 wangshao1 merged commit e981599 into OpenAtomFoundation:3.5 Jun 13, 2025
12 checks passed
byseea11 pushed a commit to byseea11/pikiwidb that referenced this pull request Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

☢️ Bug Something isn't working ✏️ Feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants