Skip to content

fix: added the correct loading of admin-cmd-list in the configuration file #3077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mixficsol merged 2 commits into from
Apr 9, 2025
Merged

fix: added the correct loading of admin-cmd-list in the configuration file #3077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08ba311
added the correct loading of admin-cmd-list in the configuration file
Apr 2, 2025
533a758
Merge branch 'unstable' of github.com:OpenAtomFoundation/pika into un…
Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conf/pika.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ slow-cmd-list :
# List of commands considered as administrative. These commands will be handled by the admin thread pool. Modify this list as needed.
# Default commands: info, ping, monitor
# This parameter is only supported by the CONFIG GET command and not by CONFIG SET.
admin-cmd-list : info, ping, monitor
admin-cmd-list : info, ping, monitor, auth, config

# The number of threads to write DB in slaveNode when replicating.
# It's preferable to set slave's sync-thread-num value close to master's thread-pool-size.
Expand Down
5 changes: 1 addition & 4 deletions src/pika_conf.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,7 @@ int PikaConf::Load() {

std::string admin_cmd_list;
GetConfStr("admin-cmd-list", &admin_cmd_list);
if (admin_cmd_list == "") {
admin_cmd_list = "info, monitor, ping";
SetAdminCmd(admin_cmd_list);
}
SetAdminCmd(admin_cmd_list);

std::string unfinished_full_sync;
GetConfStr("internal-used-unfinished-full-sync", &unfinished_full_sync);
Expand Down
Loading