Skip to content

fix: Force CMake to run with the policy behavior of version 3.5 to avoid c… #3075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mixficsol merged 1 commit into from
Apr 3, 2025
Merged

fix: Force CMake to run with the policy behavior of version 3.5 to avoid c… #3075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/pika.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ jobs:

- name: Cleanup
run: |
rm -rf ./deps
rm -rf ./buildtrees

- uses: actions/upload-artifact@v4
Expand Down Expand Up @@ -108,8 +107,7 @@ jobs:

- name: Cleanup
run: |
rm -rf ./deps
rm -rf ./buildtrees
rm -rf ./buildtrees

- name: Test
working-directory: ${{ github.workspace }}/build
Expand Down Expand Up @@ -170,8 +168,7 @@ jobs:
run: |
cp deps/lib/libz.1.dylib .
cp deps/lib/libz.1.dylib tests/integration/
rm -rf ./deps
rm -rf ./buildtree
rm -rf ./buildtrees

- name: Test
working-directory: ${{ github.workspace }}/build
Expand Down
24 changes: 24 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,8 @@ ExternalProject_Add(gtest
LOG_INSTALL
1
CMAKE_ARGS
# Force CMake to run with the policy behavior of version 3.5 to avoid cases where a higher version of CMake does not compile
-DCMAKE_POLICY_VERSION_MINIMUM=3.5
-DCMAKE_INSTALL_PREFIX=${STAGED_INSTALL_PREFIX}
-DCMAKE_BUILD_TYPE=${LIB_BUILD_TYPE}
BUILD_ALWAYS
Expand Down Expand Up @@ -192,6 +194,8 @@ ExternalProject_Add(gflags
BUILD_ALWAYS
1
CMAKE_ARGS
# Force CMake to run with the policy behavior of version 3.5 to avoid cases where a higher version of CMake does not compile
-DCMAKE_POLICY_VERSION_MINIMUM=3.5
-DCMAKE_INSTALL_PREFIX=${STAGED_INSTALL_PREFIX}
-DCMAKE_BUILD_TYPE=${LIB_BUILD_TYPE}
-DGFLAGS_NAMESPACE=gflags
Expand Down Expand Up @@ -266,6 +270,8 @@ ExternalProject_Add(glog
BUILD_ALWAYS
1
CMAKE_ARGS
# Force CMake to run with the policy behavior of version 3.5 to avoid cases where a higher version of CMake does not compile
-DCMAKE_POLICY_VERSION_MINIMUM=3.5
-DCMAKE_INSTALL_PREFIX=${STAGED_INSTALL_PREFIX}
-DCMAKE_BUILD_TYPE=${LIB_BUILD_TYPE}
-DWITH_GFLAGS=ON
Expand Down Expand Up @@ -307,6 +313,8 @@ ExternalProject_Add(snappy
LOG_INSTALL
1
CMAKE_ARGS
# Force CMake to run with the policy behavior of version 3.5 to avoid cases where a higher version of CMake does not compile
-DCMAKE_POLICY_VERSION_MINIMUM=3.5
-DCMAKE_INSTALL_PREFIX=${STAGED_INSTALL_PREFIX}
-DCMAKE_BUILD_TYPE=${LIB_BUILD_TYPE}
-DSNAPPY_BUILD_TESTS=OFF
Expand Down Expand Up @@ -345,6 +353,8 @@ ExternalProject_Add(zstd
SOURCE_SUBDIR
build/cmake
CMAKE_ARGS
# Force CMake to run with the policy behavior of version 3.5 to avoid cases where a higher version of CMake does not compile
-DCMAKE_POLICY_VERSION_MINIMUM=3.5
-DCMAKE_INSTALL_PREFIX=${STAGED_INSTALL_PREFIX}
-DCMAKE_BUILD_TYPE=${LIB_BUILD_TYPE}
-DBUILD_TESTING=OFF
Expand Down Expand Up @@ -381,6 +391,8 @@ ExternalProject_Add(fmt
LOG_INSTALL
1
CMAKE_ARGS
# Force CMake to run with the policy behavior of version 3.5 to avoid cases where a higher version of CMake does not compile
-DCMAKE_POLICY_VERSION_MINIMUM=3.5
-DCMAKE_INSTALL_PREFIX=${STAGED_INSTALL_PREFIX}
-DCMAKE_BUILD_TYPE=${LIB_BUILD_TYPE}
BUILD_ALWAYS
Expand Down Expand Up @@ -422,6 +434,8 @@ ExternalProject_Add(lz4
SOURCE_SUBDIR
build/cmake
CMAKE_ARGS
# Force CMake to run with the policy behavior of version 3.5 to avoid cases where a higher version of CMake does not compile
-DCMAKE_POLICY_VERSION_MINIMUM=3.5
-DCMAKE_INSTALL_PREFIX=${STAGED_INSTALL_PREFIX}
-DCMAKE_BUILD_TYPE=${LIB_BUILD_TYPE}
-DBUILD_TESTING=OFF
Expand Down Expand Up @@ -458,6 +472,8 @@ ExternalProject_Add(zlib
LOG_INSTALL
1
CMAKE_ARGS
# Force CMake to run with the policy behavior of version 3.5 to avoid cases where a higher version of CMake does not compile
-DCMAKE_POLICY_VERSION_MINIMUM=3.5
-DCMAKE_INSTALL_PREFIX=${STAGED_INSTALL_PREFIX}
-DCMAKE_BUILD_TYPE=${LIB_BUILD_TYPE}
-DZLIB_USE_STATIC_LIBS=ON
Expand Down Expand Up @@ -489,6 +505,8 @@ if(CMAKE_SYSTEM_NAME MATCHES "Linux")
LOG_INSTALL
1
CMAKE_ARGS
# Force CMake to run with the policy behavior of version 3.5 to avoid cases where a higher version of CMake does not compile
-DCMAKE_POLICY_VERSION_MINIMUM=3.5
-DCMAKE_INSTALL_PREFIX=${STAGED_INSTALL_PREFIX}
-DCMAKE_BUILD_TYPE=${LIB_BUILD_TYPE}
-DGPERFTOOLS_BUILD_STATIC=ON
Expand Down Expand Up @@ -558,6 +576,8 @@ ExternalProject_Add(protobuf
SOURCE_SUBDIR
cmake
CMAKE_ARGS
# Force CMake to run with the policy behavior of version 3.5 to avoid cases where a higher version of CMake does not compile
-DCMAKE_POLICY_VERSION_MINIMUM=3.5
-DCMAKE_INSTALL_PREFIX=${STAGED_INSTALL_PREFIX}
-DCMAKE_BUILD_TYPE=${LIB_BUILD_TYPE}
-DBUILD_SHARED_LIBS=FALSE
Expand Down Expand Up @@ -607,6 +627,8 @@ ExternalProject_Add(rocksdb
BUILD_ALWAYS
1
CMAKE_ARGS
# Force CMake to run with the policy behavior of version 3.5 to avoid cases where a higher version of CMake does not compile
-DCMAKE_POLICY_VERSION_MINIMUM=3.5
-DCMAKE_INSTALL_PREFIX=${STAGED_INSTALL_PREFIX}
-DCMAKE_PREFIX_PATH=${CMAKE_PREFIX_PATH}
-DCMAKE_BUILD_TYPE=${LIB_BUILD_TYPE}
Expand Down Expand Up @@ -648,6 +670,8 @@ ExternalProject_Add(rediscache
SOURCE_SUBDIR
""
CMAKE_ARGS
# Force CMake to run with the policy behavior of version 3.5 to avoid cases where a higher version of CMake does not compile
-DCMAKE_POLICY_VERSION_MINIMUM=3.5
-DCMAKE_INSTALL_PREFIX=${STAGED_INSTALL_PREFIX}
-DCMAKE_INSTALL_INCLUDEDIR=${INSTALL_INCLUDEDIR}
-DCMAKE_INSTALL_LIBDIR=${INSTALL_LIBDIR}
Expand Down
Loading