Skip to content

fix: Example Repair the subjective and objective offline logic of noeds #3049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wangshao1 merged 2 commits into from
Mar 19, 2025
+11 −4
Merged

fix: Example Repair the subjective and objective offline logic of noeds #3049

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4453656
Example Repair the subjective and objective offline logic of primary …
Mar 19, 2025
d3f3394
fix comment
Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions codis/pkg/topom/topom_sentinel.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,17 @@ func (s *Topom) checkAndUpdateGroupServerState(conf *Config, group *models.Group
}

// Start the election master node
if groupServer.State == models.GroupServerStateOffline && isGroupMaster(state, group) {
*masterOfflineGroups = append(*masterOfflineGroups, group)
} else {
*slaveOfflineGroups = append(*slaveOfflineGroups, group)
// Currently, both primary and secondary nodes have subjective and objective logics.
// If it is subjective, we will not perform any operation. If more than 10 probe counts
// fail, it is defined as objective logics, If it is an objective offline, we will add the
// node to masterOfflineGroups or slaveOfflineGroups respectively, and then notify the Proxy
// to change the meta information
if groupServer.State == models.GroupServerStateOffline {
if isGroupMaster(state, group) {
*masterOfflineGroups = append(*masterOfflineGroups, group)
} else {
*slaveOfflineGroups = append(*slaveOfflineGroups, group)
}
}
}
} else {
Expand Down
Loading