Skip to content

Fix tab flicker when changing package versions by preventing content flash during tab restoration #10565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fix tab flicker when changing package versions by preventing content flash during tab restoration #10565

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cddc2ff
Initial plan
Copilot Sep 4, 2025
2a38e2d
Fix tab flicker on version change by preventing initial tab content v…
Copilot Sep 5, 2025
376434b
Improve tab flicker fix to dynamically detect active tab instead of h…
Copilot Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions src/NuGetGallery/Scripts/gallery/page-display-package.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,21 @@
$(function () {
'use strict';

// Prevent tab flicker by checking localStorage early and hiding content if needed
var storage = window['localStorage'];
var bodyStorageKey = 'preferred_body_tab';
var shouldHideContentInitially = false;

if (storage && !window.location.hash) {
var preferredBodyTab = storage.getItem(bodyStorageKey);
// Check if there's a stored preference that differs from the server-rendered active tab
if (preferredBodyTab && $('.body-tabs .nav-tabs li.active a').attr('id') !== preferredBodyTab) {
shouldHideContentInitially = true;
// Temporarily hide the tab content to prevent flicker
$('.body-tab-content').css('visibility', 'hidden');
}
}

// Configure the rename information container
window.nuget.configureExpander("rename-content-container", "ChevronDown", null, "ChevronUp");
configureExpanderWithEnterKeydown($('#show-rename-content-container'));
Expand Down Expand Up @@ -90,9 +105,7 @@
}

// Restore previously selected package manager and body tab.
var storage = window['localStorage'];
var packageManagerStorageKey = 'preferred_package_manager';
var bodyStorageKey = 'preferred_body_tab';
var restorePreferredBodyTab = true;

var windowHash = window.location.hash;
Expand All @@ -107,6 +120,12 @@
$(windowHash).tab('show');
// don't restore body tab given the window hash
restorePreferredBodyTab = false;

// If we have a hash, we can safely show content now
if (shouldHideContentInitially) {
$('.body-tab-content').css('visibility', 'visible');
shouldHideContentInitially = false;
}
}

if (storage) {
Expand All @@ -125,6 +144,11 @@
}
}

// Restore visibility if we hid content to prevent flicker
if (shouldHideContentInitially) {
$('.body-tab-content').css('visibility', 'visible');
}

var usedByClamped = false;
var usedByTab = $('#usedby-tab');

Expand Down